test: Fix and re-enable test reliant on managed etcd #11818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensure `global.identityAllocationMode=kvstore` is set; the default is `crd` which is not what etcd test was meant to be testing - it looks like there is still a deadlock occuring when default `crd` modes is used Fixes: #11690 Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
|
Please set the appropriate release note label. |
|
test-me-please |
tgraf
approved these changes
Jun 2, 2020
pchaigno
approved these changes
Jun 2, 2020
pchaigno
added
the
ci/flake
|
Most Jenkins jobs have passed, I would say we can merge this. I am on the phone now, cannot check all the failures, it would be good to paste a summary here for the record. |
|
Most failures seem to be related to |
|
The tests that failed, failed because of: |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
global.identityAllocationMode=kvstoreis set; the defaultis
crdwhich is not what etcd test was meant to be testingcrdmodes is used
Fixes: #11690