Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Remove incorrect comment on flakyness #12821

Merged
merged 1 commit into from
Aug 8, 2020
Merged

test: Remove incorrect comment on flakyness #12821

merged 1 commit into from
Aug 8, 2020

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Aug 7, 2020

This comment was added in #11772 when the test was disabled, but it wasn't removed once the test was fixed and reenabled in #11818.

Fixes: #11818

@pchaigno
test: Remove incorrect comment on flakyness
1a1a2e3 
This comment was added in 210d558 when the test was disabled, but it
wasn't removed once the test was fixed and reenabled in 6fe8d09.

Fixes: 6fe8d09 ("test: Fix and re-enable test reliant on managed etcd")
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Aug 7, 2020
@pchaigno pchaigno requested a review from a team as a code owner August 7, 2020 17:42
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 37.109% when pulling 1a1a2e3 on pr/pchaigno/remove-incorrect-comment into 0dc3adc on master.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 7, 2020
@tklauser tklauser merged commit 00bbb9c into master Aug 8, 2020
@tklauser tklauser deleted the pr/pchaigno/remove-incorrect-comment branch August 8, 2020 12:13
@joestringer joestringer mentioned this pull request Oct 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@joestringer joestringer joestringer approved these changes

@christarazi christarazi christarazi approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pchaigno @coveralls @tklauser @joestringer @christarazi