Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/k8s: decrease CEP status initialization #11829

Merged
merged 2 commits into from Jun 4, 2020
Merged

pkg/k8s: decrease CEP status initialization #11829

merged 2 commits into from Jun 4, 2020

Conversation

aanm
Copy link
Member

@aanm aanm commented Jun 2, 2020

When an endpoint is created, its status is only created 10 seconds
after. This happens because Kubernetes ignores the status field of a CRD
object on its initialization and Cilium has a controller running every
10 seconds.

In order to have a shorter CEP update window, Cilium can create the
status field immediately after the creation of the CEP without waiting
for the next execution of the CEP controller to be executed.

Signed-off-by: André Martins andre@cilium.io

Fixes #11751

@aanm aanm added release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.8 labels Jun 2, 2020
@aanm aanm requested a review from a team June 2, 2020 16:13
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Jun 2, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.0 Jun 2, 2020
@aanm
Copy link
Member Author

aanm commented Jun 2, 2020

test-me-please

@coveralls
Copy link

coveralls commented Jun 2, 2020 •
edited

Coverage Status

Coverage decreased (-0.02%) to 36.908% when pulling f2c55c7 on pr/decrease-cep-update-window into a20dcd1 on master.

brb
brb requested changes Jun 2, 2020
View reviewed changes
Copy link
Member

@brb brb left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert #11771 as the part of this PR, and see whether we don't hit the flake anymore?

@aanm
pkg/k8s: decrease CEP status initialization
e1ed061 
When an endpoint is created, its status is only created 10 seconds
after. This happens because Kubernetes ignores the status field of a CRD
object on its initialization and Cilium has a controller running every
10 seconds.

In order to have a shorter CEP update window, Cilium can create the
status field immediately after the creation of the CEP without waiting
for the next execution of the CEP controller to be executed.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/decrease-cep-update-window branch from 2b7f272 to 92a3948 Compare June 2, 2020 17:38
@aanm aanm requested a review from a team as a code owner June 2, 2020 17:38
@maintainer-s-little-helper
Copy link

Commit 92a3948fab08e7b84d207a4404eb071530041de6 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jun 2, 2020
@aanm aanm requested a review from brb June 2, 2020 17:39
@aanm
Revert "test: Wait for IPCache entries in testSessionAffinity"
f2c55c7 
This reverts commit 9accb13.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/decrease-cep-update-window branch from 92a3948 to f2c55c7 Compare June 2, 2020 17:39
@maintainer-s-little-helper
Copy link

Commit 92a3948fab08e7b84d207a4404eb071530041de6 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@aanm aanm removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jun 2, 2020
@aanm
Copy link
Member Author

aanm commented Jun 2, 2020

test-focus K8sServicesTest.*Tests NodePort with sessionAffinity from outside

@aanm
Copy link
Member Author

aanm commented Jun 2, 2020

test-focus K8sServicesTest.*

@aanm
Copy link
Member Author

aanm commented Jun 2, 2020

test-me-please

@brb
Copy link
Member

brb commented Jun 3, 2020 •
edited

test-focus K8sServicesTest.* (giving it more tries to ensure that the flake is gone)

@aanm
Copy link
Member Author

aanm commented Jun 3, 2020 •
edited

hit #8945 https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated-Focus/225/

@aanm
Copy link
Member Author

aanm commented Jun 3, 2020 •
edited

test-focus K8sServicesTest.* build aborted? https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated-Focus/229/execution/node/121/log/

@aanm
Copy link
Member Author

aanm commented Jun 3, 2020 •
edited

test-focus K8sServicesTest.* Green

1 similar comment
@aanm
Copy link
Member Author

aanm commented Jun 3, 2020 •
edited

test-focus K8sServicesTest.* Green

@aanm
Copy link
Member Author

aanm commented Jun 3, 2020 •
edited

retest-net-next previous net-next failure https://jenkins.cilium.io/job/Cilium-PR-K8s-oldest-net-next/539/

@aanm
Copy link
Member Author

aanm commented Jun 4, 2020 •
edited

retest-net-next previous net-next failure https://jenkins.cilium.io/job/Cilium-PR-K8s-oldest-net-next/572/

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 4, 2020
@tgraf tgraf merged commit caf3a93 into master Jun 4, 2020
1.8.0 automation moved this from In progress to Merged Jun 4, 2020
@tgraf tgraf deleted the pr/decrease-cep-update-window branch June 4, 2020 09:39
@tklauser tklauser mentioned this pull request Jun 4, 2020
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.8 in 1.8.0 Jun 5, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.8 in 1.8.0 Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

@nebril nebril nebril approved these changes

@tgraf tgraf tgraf approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
1.8.0
Backport done to v1.8
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decrease IPCache CEP update window
7 participants
@aanm @coveralls @brb @nebril @tgraf @tklauser @borkmann