Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: fixed hubble servicemonitor matchLabels parameter #11886

Merged
merged 1 commit into from Jun 4, 2020
Merged

helm: fixed hubble servicemonitor matchLabels parameter #11886

merged 1 commit into from Jun 4, 2020

Conversation

mvisonneau
Copy link
Contributor

The k8s-app label of the hubble-metrics service is equal to hubble and not cilium

https://github.com/cilium/cilium/blob/master/install/kubernetes/cilium/charts/agent/templates/svc.yaml#L28

@mvisonneau
helm: fixed hubble servicemonitor matchLabels parameter
58dc784 
the 'k8s-app' label of the 'hubble-metrics' service is equal to 'hubble' and not 'cilium'

Signed-off-by: Maxime VISONNEAU <maxime.visonneau@gmail.com>
@mvisonneau mvisonneau requested review from a team as code owners June 4, 2020 09:15
@mvisonneau mvisonneau requested a review from a team June 4, 2020 09:15
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Jun 4, 2020
@gandro gandro added area/helm Impacts helm charts and user deployment experience release-note/misc This PR makes changes that have no direct user impact. labels Jun 4, 2020
gandro
gandro approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you!

@gandro
Copy link
Member

gandro commented Jun 4, 2020

test-me-please

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.0 Jun 4, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 36.942% when pulling 58dc784 on mvisonneau:chart/hubble_servicemonitor into ec385b2 on cilium:master.

rolinh
rolinh approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 4, 2020
@nebril nebril merged commit 11336de into cilium:master Jun 4, 2020
1.8.0 automation moved this from In progress to Merged Jun 4, 2020
@tklauser tklauser mentioned this pull request Jun 5, 2020
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 5, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 5, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 6, 2020
@mvisonneau mvisonneau deleted the chart/hubble_servicemonitor branch June 9, 2020 09:51
@guilhermef guilhermef mentioned this pull request Dec 22, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@rolinh rolinh rolinh approved these changes

@nebril nebril nebril approved these changes

Assignees
No one assigned
Labels
area/helm Impacts helm charts and user deployment experience ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
1.8.0
Backport done to v1.8
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mvisonneau @gandro @coveralls @rolinh @nebril @tklauser @joestringer