Fixing Hubble ServiceMonitor k8s-app label #14473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
maintainer-s-little-helper
bot
added
dont-merge/needs-sign-off
guilhermef
force-pushed
the
fix-hubble-service-monitor
branch
from
d43b4ae
to
e8f0bae
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
guilhermef
force-pushed
the
fix-hubble-service-monitor
branch
2 times, most recently
from
e855877
to
0705d3e
Compare
gandro
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
fristonio
approved these changes
Dec 22, 2020
gandro
approved these changes
Dec 22, 2020
kaworu
approved these changes
Dec 22, 2020
@guilhermef this is referencing a closed PR where I would have expected an open issue instead. Whas that intended? |
Yes, that's a regression, it was fixed on the referenced PR before |
christarazi
approved these changes
Dec 23, 2020
christarazi
requested changes
Dec 23, 2020
The current ServiceMonitor is trying to match a `k8s-app=cilium`, but the current service has `k8s-app=hubble`. https://github.com/cilium/cilium/blob/master/install/kubernetes/cilium/templates/cilium-agent-service.yaml#L56 Signed-off-by: Guilherme Souza <guilhermef@users.noreply.github.com> Fixes: e9cb43c ("Helm: full refactor of helm charts, default values implemented, tests updated, kind cni integration")
guilhermef
force-pushed
the
fix-hubble-service-monitor
branch
from
0705d3e
to
2d2ff3b
Compare
|
test-me-please |
christarazi
approved these changes
Dec 23, 2020
|
@guilhermef Thanks for your PR 🎉. I just run into the same issue and also found the wrong label matching - but you now took the work from me to create a PR - thanks! Would be awesome to see this PR merged in the next release 1.9.2. Regards, |
|
net-next hit #13071. All other CI has passed and we have code owner approval. Merging. |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current ServiceMonitor is trying to match a
k8s-app=cilium, but the current service hask8s-app=hubble.https://github.com/cilium/cilium/blob/master/install/kubernetes/cilium/templates/cilium-agent-service.yaml#L56
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: #11886