Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Rework live-preview to use docker container #11940

Merged
merged 1 commit into from Jun 8, 2020
Merged

docs: Rework live-preview to use docker container #11940

merged 1 commit into from Jun 8, 2020

Conversation

joestringer
Copy link
Member

This way, we can rely upon the dependencies provided by the container
rather than forcing folks to install various dependencies (even if
mainly managed by pipenv).

@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Jun 6, 2020
@joestringer
docs: Rework live-preview to use docker container
ccf2a86 
This way, we can rely upon the dependencies provided by the container
rather than forcing folks to install various dependencies (even if
mainly managed by pipenv).

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer force-pushed the submit/docs-live-preview-docker branch from 2796799 to ccf2a86 Compare June 6, 2020 01:38
@joestringer joestringer added needs-backport/1.8 release-note/misc This PR makes changes that have no direct user impact. labels Jun 6, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.0 Jun 6, 2020
@joestringer joestringer mentioned this pull request Jun 6, 2020
Merged
@joestringer joestringer marked this pull request as ready for review June 6, 2020 01:46
@joestringer joestringer requested review from a team as code owners June 6, 2020 01:46
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 36.968% when pulling ccf2a86 on joestringer:submit/docs-live-preview-docker into a7cbab1 on cilium:master.

christarazi
christarazi approved these changes Jun 6, 2020
View reviewed changes
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

michi-covalent
michi-covalent approved these changes Jun 6, 2020
View reviewed changes
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another big win here is that we don't get inconsistent spell check results because this uses the dictionary in the docker image.

having said that, live reload doesn't seem to work on mac :( i don't consider that a blocker though.

@borkmann borkmann merged commit 9603331 into cilium:master Jun 8, 2020
1.8.0 automation moved this from In progress to Merged Jun 8, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.0 Jun 8, 2020
@tklauser tklauser mentioned this pull request Jun 8, 2020
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.0 Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christarazi christarazi christarazi approved these changes

@michi-covalent michi-covalent michi-covalent approved these changes

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
1.8.0
Backport done to v1.8
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@joestringer @coveralls @christarazi @michi-covalent @tklauser @borkmann @aanm