Implement per-provider operator deployments in Helm #12029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please set the appropriate release note label. |
1 similar comment
|
Please set the appropriate release note label. |
joestringer
added
the
release-note/minor
|
test-focus K8sUpdates |
joestringer
force-pushed
the
submit/helm-operator-fixes
branch
from
88e7f5b
to
6136c92
Compare
|
test-focus K8sUpdates |
aanm
approved these changes
Jun 11, 2020
|
test-me-please |
tgraf
approved these changes
Jun 11, 2020
tgraf
requested changes
Jun 11, 2020
There was a problem hiding this comment.
The following needs to be changed as well:
docker tag "cilium/cilium:$2" "$1/cilium/cilium:$2"
docker tag "cilium/cilium:$2" "$1/cilium/cilium-dev:$2"
docker tag "cilium/operator:$2" "$1/cilium/operator:$2"
docker tag "cilium/hubble-relay:$2" "$1/cilium/hubble-relay:$2"
tgraf
force-pushed
the
submit/helm-operator-fixes
branch
from
6136c92
to
3cf8464
Compare
|
test-focus K8sUpdates |
Update the helm charts for for generic, aws and azure operator images. Fixes: cilium#11800 Signed-off-by: Sean Winn <sean@isovalent.com> Signed-off-by: Joe Stringer <joe@cilium.io>
tgraf
force-pushed
the
submit/helm-operator-fixes
branch
from
3cf8464
to
41ac24b
Compare
|
test-focus K8sUpdates |
joestringer
commented
Jun 11, 2020
Comment on lines
+15
to
+25
| docker-image: clean docker-image-no-clean docker-plugin-image docker-hubble-relay-image | ||
| $(MAKE) docker-operator-image | ||
| $(MAKE) docker-operator-aws-image | ||
| $(MAKE) docker-operator-azure-image | ||
| $(MAKE) docker-operator-generic-image | ||
|
|
||
| docker-image-unstripped: clean docker-image-no-clean-unstripped docker-plugin-image-unstripped docker-hubble-relay-image-unstripped | ||
| $(MAKE) docker-operator-image-unstripped | ||
| $(MAKE) docker-operator-aws-image-unstripped | ||
| $(MAKE) docker-operator-azure-image-unstripped | ||
| $(MAKE) docker-operator-generic-image-unstripped |
There was a problem hiding this comment.
:) would've expected these to be largely equivalent. "If you didn't know, now you know"
👍
|
Focus passed 🎉 |
|
test-me-please |
|
This PR currently uses the brute-force method to resolve this. We should avoid building all operator images in the CI in a follow-up PR. |
tgraf
approved these changes
Jun 11, 2020
|
Hit known flake #10929: |
|
The rest is green, merging. |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.0
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.0
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the helm charts for for generic, aws and azure operator images.
Fixes: #11800
This is a simplification of the minimal required changes from #11837 for the v1.8.0 release.