Fix missing operator-generic in upstream k8s tests #12055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
priority/release-blocker
release-note/misc
|
test-upstream-k8s |
aanm
force-pushed
the
pr/fix-generic-operator
branch
from
c3c10f5
to
8b03c05
Compare
|
test-upstream-k8s |
joestringer
approved these changes
Jun 12, 2020
test/provision/compile.sh
Outdated
| @@ -45,13 +48,28 @@ then | |||
|
|
|||
| if [[ "${CILIUM_OPERATOR_IMAGE}" == "" ]]; then | |||
| echo "building cilium-operator image..." | |||
| make LOCKDEBUG=1 docker-operator-image | |||
| echo "tagging cilium-operator image..." | |||
| make LOCKDEBUG=1 docker-operator-image docker-operator-aws-image docker-operator-azure-image docker-operator-generic-image | |||
There was a problem hiding this comment.
We should probably reference #12035 here as well
(The equivalent change for the regular cilium build is in the makefile)
tgraf
approved these changes
Jun 12, 2020
rolinh
approved these changes
Jun 12, 2020
Also build all operator images by default so the upstream tests will have the generic image available. Fixes: 2773d06 ("Implement per-provider operator deployments") Signed-off-by: André Martins <andre@cilium.io>
Fixes: 2773d06 ("Implement per-provider operator deployments") Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/fix-generic-operator
branch
from
8b03c05
to
dac9ffa
Compare
|
test-upstream-k8s |
|
test-me-please |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.0
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.0
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some bugs introduced by #12029