contrib: extend checkpr.sh to watch for Smoke Tests completion #12058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmonnet
added
pending-review
area/misc
Use notify-send in addition to audio bell to tell users when Jenkins has finished testing the PR. Signed-off-by: Quentin Monnet <quentin@isovalent.com>
Add -m and -q options to checkpr.sh to silence audio and text notifications, respectively. Signed-off-by: Quentin Monnet <quentin@isovalent.com>
Add a -s option to checkpr.sh so we can watch for the completion of Smoke Tests (from GitHub actions) instead of the Jenkins job. This is so we can launch the Jenkins CI tests once the Smoke Tests are finished (and succeeded, of course). Signed-off-by: Quentin Monnet <quentin@isovalent.com>
qmonnet
force-pushed
the
pr/qmonnet/checkpr
branch
from
b10e98f
to
40950f7
Compare
|
Fixed a leftover from development (oops!). diffdiff --git a/contrib/scripts/checkpr.sh b/contrib/scripts/checkpr.sh
index 1cf7cf11d8e6..ebbd8f1abfec 100755
--- a/contrib/scripts/checkpr.sh
+++ b/contrib/scripts/checkpr.sh
@@ -82,7 +82,6 @@ check_smoke_test() {
PR_ID=$1
# Get branch (HEAD) for PR
- BRANCH="pr/qmonnet/disable_fragtest_4.19"
BRANCH=$(curl -s "https://api.github.com/repos/cilium/cilium/pulls/$PR_ID" | jq -r '.head.ref')
# Get workflow ID for latest Smoke tests run for that branch |
nebril
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend
contrib/scripts/checkpr.shwith options, including a-soption to watch for the completion of Smoke Tests (from GitHub actions) instead of the Jenkins job for the given PR. This is so we can launch the Jenkins CI tests once the Smoke Tests are finished.Usage: Check for Jenkins status as before:
Check for Smoke Tests instead with the
-soption: