test,daemon: Fix repeated devices #12176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brb
added
pending-review
area/CI
|
test-me-please |
pchaigno
approved these changes
Jun 18, 2020
|
Coverage increased (+0.02%) to 37.113% when pulling 19931f0ce9343207ede76e7149f0ff0cb10d21b9 on pr/brb/ci-fix-default-devices into d28767b on master. |
|
retest-net-next |
brb
force-pushed
the
pr/brb/ci-fix-default-devices
branch
from
19931f0
to
7b3d3fe
Compare
It was reported that GetDefaultIface() can return multiple ifaces with a
default route. E.g.:
time="2020-06-17T12:54:34-07:00" level=debug msg="running command:
kubectl exec -n cilium log-gatherer-gg44r -- ip -o r | grep default |
grep -o 'dev [a-zA-Z0-9]*' | cut -d' ' -f2"
cmd: "kubectl exec -n cilium log-gatherer-gg44r -- ip -o r | grep
default | grep -o 'dev [a-zA-Z0-9]*' | cut -d' ' -f2" exitCode: 0
duration: 511.169541ms stdout:
eth0
eth0
Improve the helper by returning only a single value.
Debugged-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Martynas Pumputis <m@lambda.lt>
This commit removes repeated devices passed via --devices to prevent from attaching the same bpf_host program multiple times to it. Signed-off-by: Martynas Pumputis <m@lambda.lt>
|
test-me-please |
christarazi
approved these changes
Jun 18, 2020
joestringer
approved these changes
Jun 18, 2020
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.0
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.0
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
GetDefaultIface()test helper will return a single device.--devicesby a user./cc @pchaigno @jrajahalme
Reviewable per commit.