v1.6 backports 2020-07-01 #12356
Merged
v1.6 backports 2020-07-01 #12356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit ab5f506 ] Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
[ upstream commit a754a0c ] Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
Fixes: #10981 Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
[ upstream commit a1b1cd6 ] Istio GSG and Istio CI test are modified to downloading the current version of the cilium-istioctl and use it for Istio deployment. Istioctl bundles the helm charts and uses a helm library to configure Kubernetes. Cilium version (cilium-istioctl) adds support for Cilium-specific configuration of the sidecar proxies and defaults to Cilium builds of pilot and sidecar proxy so that the user does not need to set the images explicitly. 'bookinfo-gateway.yaml' is added to examples so that it can be used in the GSG without requiring downloading Istio yamls. Both Istio GSG and the CI test now use a namespace label for automatic sidecar injection. This simplifies application deployment and allows easier future CI updates as pre-formed application/Istio yamls can now be removed. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
jrajahalme
added
kind/backports
|
test-backport-1.6 |
aanm
approved these changes
Jul 1, 2020
|
@jrajahalme it seems the failures were related with the changes from the PR: |
[ upstream commit 53f7c5f ] Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
[ upstream commit eaea136 ] Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
[ upstream commit 471fe63 ] Skip Istio test if running cilium-istioctl is not supported for the current Go runtime. Support running Istio test from OSX by downloading the osx version of cilium-istioctl if the test suite is running in OSX. This allows running the Istio test on a remote cluster (e.g., GKE) when Ginkgo is running on OSX. On Windows the test is skipped, even though the cilium-istioctl binary is released also for Windows, but this has not been tested yet. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
[ upstream commit 12ef7d1 ] Only use the Ginkgo runtime OS for determining which cilium-istioctl binary to download is the command executor is local, otherwise default to "linux". This supports Ginkgo running in OSX both with local and SSH Executors. Fixes: #11905 Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
[ upstream commit 640f669 ] Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
[ upstream commit ca767ee ] '--no-wildcard' allows the socket match to find zero-bound (listening) sockets, which we do not want, as this may intercept (reply) traffic intended for other nodes when an ephemeral source port number allocated in one node happens to be the same as the allocated proxy port number in 'this' node (the node doing the iptables socket match changed here). Fixes: #12241 Related: #8864 Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
[ upstream commit 31f8ba0 ] Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
jrajahalme
force-pushed
the
pr/v1.6-backport-2020-07-01
branch
from
68e17f3
to
fda2965
Compare
|
test-backport-1.6 |
|
Hit known flake #11895. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, you can update the PR labels via: