iptables: Remove '--nowildcard' from socket match #12248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrajahalme
added
kind/bug
|
test-me-please |
|
retest-net-next |
1 similar comment
|
retest-net-next |
|
test-only --k8s_version=1.18 --focus="K8s.*AutoDirectNodeRoutes" --kernel_version=net-next |
jrajahalme
force-pushed
the
pr/jrajahalme/fix-iptables-socket-match
branch
from
bb07b3e
to
cd503fe
Compare
nebril
requested changes
Jun 25, 2020
test/helpers/kubectl.go
Outdated
| res := kub.CiliumExecContext(context.TODO(), ciliumPod, pickDNSProxyPort) | ||
| if !res.WasSuccessful() { | ||
| ginkgoext.Failf("Cannot find DNS proxy port on %s", ciliumPod) | ||
| return 0 |
There was a problem hiding this comment.
nit: this line will never get executed
test/helpers/kubectl.go
Outdated
| return 0 | ||
| } | ||
| portStr := res.GetStdOut().String() | ||
| gomega.Expect(portStr).ShouldNot(gomega.BeEmpty(), "No DNS proxy port found on %s", ciliumPod) |
There was a problem hiding this comment.
Please use ExpectWithOffset, this will make test failure point to parent call instead of this line.
There was a problem hiding this comment.
OK, so the offset value of 1 will point the failure to caller, 2 would point the failure to the caller's caller etc.?
qmonnet
reviewed
Jun 25, 2020
jrajahalme
force-pushed
the
pr/jrajahalme/fix-iptables-socket-match
branch
from
cd503fe
to
65a5cb0
Compare
|
test-me-please |
nebril
approved these changes
Jun 25, 2020
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.6
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Backport done to v1.7
in 1.7.6
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Backport done to v1.7
in 1.7.6
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.6
in 1.6.10
maintainer-s-little-helper
bot
moved this from Backport pending to v1.6
to Backport done to v1.6
in 1.6.10
This was referenced Jul 8, 2020
Closed
jrajahalme
added a commit
that referenced
this pull request
Jul 8, 2020
Since we address NodePort in k8s2 using the DNS proxy port of k8s2 as the source port from k8s1, one round is enough regardless of the backend selection, as in both cases the replies are reverse NATted at k8s2 (where the port conflict was happening before it was fixed by #12248). Fixes: #12336 Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
jrajahalme
added a commit
that referenced
this pull request
Jul 10, 2020
Since we address NodePort in k8s2 using the DNS proxy port of k8s2 as the source port from k8s1, one round is enough regardless of the backend selection, as in both cases the replies are reverse NATted at k8s2 (where the port conflict was happening before it was fixed by #12248). Fixes: #12336 Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
brb
pushed a commit
that referenced
this pull request
Jul 15, 2020
[ upstream commit 657295c ] Since we address NodePort in k8s2 using the DNS proxy port of k8s2 as the source port from k8s1, one round is enough regardless of the backend selection, as in both cases the replies are reverse NATted at k8s2 (where the port conflict was happening before it was fixed by #12248). Fixes: #12336 Signed-off-by: Jarno Rajahalme <jarno@covalent.io> Signed-off-by: Martynas Pumputis <m@lambda.lt>
christarazi
pushed a commit
that referenced
this pull request
Jul 20, 2020
[ upstream commit 657295c ] Since we address NodePort in k8s2 using the DNS proxy port of k8s2 as the source port from k8s1, one round is enough regardless of the backend selection, as in both cases the replies are reverse NATted at k8s2 (where the port conflict was happening before it was fixed by #12248). Fixes: #12336 Signed-off-by: Jarno Rajahalme <jarno@covalent.io> Signed-off-by: Martynas Pumputis <m@lambda.lt>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'--no-wildcard' allows the socket match to find zero-bound (listening)
sockets, which we do not want, as this may intercept traffic intended
for other nodes, for example, reply traffic when an ephemeral source
port number allocated in one node happens to be the same as the
allocated proxy port number in the node doing the iptables socket
match changed here.
Note to backporters: The test suite changes need not be backported
to older releases (e.g., 1.6) if these are non-trivial merge conflicts.
Fixes: #12281
Fixes: #12127
Fixes: #8945
Fixes: #10669
Fixes: #11867
Fixes: #10118
Fixes: #11313
Fixes: #12241
Fixes: #10231
Related: #8864
Signed-off-by: Jarno Rajahalme jarno@covalent.io