Replace use of github.com/pkg/errors and golang.org/x/xerrors with Go stdlib functionality #12603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use fmt.Errorf instead of the external github.com/pkg/errors to wrap error values. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Use errors.Is instead of errors.Cause from the external github.com/pkg/errors to check wrapped error values. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
added
kind/cleanup
aanm
approved these changes
Jul 21, 2020
pchaigno
approved these changes
Jul 21, 2020
Consistently use fmt.Errorf instead of the external github.com/pkg/errors to wrap error values. Also switch existing uses of fmt.Errorf to use the %w verb to wrap the underlying error properly. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
This will pull in cilium/ebpf#116 which dropped use of golang.org/x/errors and uses the Go stdlib errors package instead. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
force-pushed
the
pr/tklauser/drop-pkg-errors
branch
from
16498c7
to
a1cd0b8
Compare
|
test-me-please |
nebril
reviewed
Jul 21, 2020
sayboras
reviewed
Jul 21, 2020
qmonnet
approved these changes
Jul 21, 2020
rolinh
approved these changes
Jul 21, 2020
nebril
approved these changes
Jul 21, 2020
tgraf
approved these changes
Jul 22, 2020
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the Go stdlib error handling functionality (
errorspackage andfmt.Errorf) available since Go 1.13 instead of the external packages github.com/pkg/errors and golang.org/x/xerrors.Reviewable by commit.