helm/azure: Fatal error for CNI Azure installation

[sayboras]

Setting global.azure.enabled will change operator image to
operator-azure, which only accepts azure IPAM, and throw
fatal error for cluster-pool.

This PR is to enable node init azure step for both cases (e.g. CNI
and Azure IPAM)

Closes #13023

Signed-off-by: Tam Mach sayboras@yahoo.com

helm/azure: Fix fatal error for CNI Azure installation

TODO

• Follow GSG for azure one more time

Testing Azure CNI Chaining

$ helm install cilium install/kubernetes/cilium \
  --namespace cilium \
  --set global.cni.chainingMode=generic-veth \
  --set global.cni.customConf=true \
  --set global.nodeinit.enabled=true \
  --set nodeinit.azure=true \
  --set global.cni.configMap=cni-configuration \
  --set global.tunnel=disabled \
  --set global.masquerade=false
NAME: cilium
LAST DEPLOYED: Mon Aug 31 22:45:39 2020
NAMESPACE: cilium
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
You have successfully installed Cilium.

Your release version is 1.8.90.

For any further help, visit https://docs.cilium.io/en/v1.8/gettinghelp

$ kgpoowiden cilium                                                  
NAME                               READY   STATUS    RESTARTS   AGE     IP            NODE                                NOMINATED NODE   READINESS GATES
cilium-5hwmr                       1/1     Running   0          2m29s   10.240.0.35   aks-nodepool1-14356785-vmss000001   <none>           <none>
cilium-lj9fw                       1/1     Running   0          2m29s   10.240.0.4    aks-nodepool1-14356785-vmss000000   <none>           <none>
cilium-node-init-b28ts             1/1     Running   0          2m29s   10.240.0.4    aks-nodepool1-14356785-vmss000000   <none>           <none>
cilium-node-init-brjrn             1/1     Running   0          2m29s   10.240.0.35   aks-nodepool1-14356785-vmss000001   <none>           <none>
cilium-operator-65456488b8-74p79   1/1     Running   0          2m29s   10.240.0.35   aks-nodepool1-14356785-vmss000001   <none>           <none>
cilium-operator-65456488b8-z645x   1/1     Running   0          2m29s   10.240.0.4    aks-nodepool1-14356785-vmss000000   <none>           <none>

[christarazi]

LGTM pending one question.

[christarazi]

Do we still need to set global.azure.enabled also?

[sayboras]

Setting global.azure.enabled=true will change operator image to cilium-operator-azure as per https://github.com/cilium/cilium/blob/master/install/kubernetes/cilium/charts/operator/templates/deployment.yaml#L60. And cilium-operator-azure only allows ipam.azure mode.

Understand that global.azure.enabled might cause some confusion, keen to hear your input to make it clearer as well as backward compatible.

[kkourt]

How about we rename .azure in nodeinit to .expect-azure-vnet or similar to make it more clear?

And then maybe add an additional comment on the of this value the about its use-case? AFAIU, this is when we want to use azure but without using cilium-operator-azure that only allows ipam.azure.

[joestringer]

@kkourt 's suggestion seems reasonable. Other than that, makes sense, sounds like this should resolve the error in Azure chaining guide.

[kkourt]

Thanks!