Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.8 backports 2020-09-07 #13100

Merged
merged 3 commits into from Sep 9, 2020
Merged

v1.8 backports 2020-09-07 #13100

merged 3 commits into from Sep 9, 2020

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Sep 7, 2020

Not included due to non-trivial conflicts:

Once this PR is merged, you can update the PR labels via:

$ for pr in 13058 13024 13051; do contrib/backporting/set-labels.py $pr done 1.8; done

joestringer and others added 3 commits September 7, 2020 11:01
[ upstream commit 9f322f0 ]

The indentation here was off, causing the subsequent section to also be
considered part of the quote block. Fix it up. While we're at it,
clarify that the `agent.keepDeprecatedProbes` option should be specified
in addition to any other Helm options from the user.

Signed-off-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Paul Chaignon <paul@cilium.io>
[ upstream commit 011546b ]

Setting `global.azure.enabled` will change operator image to
`operator-azure`, which only accepts azure IPAM, and throw
fatal error for `cluster-pool`.

This PR is to enable node init to wait for azure vnet for both
cases (e.g. CNI and Azure IPAM)

Closes #13023

Signed-off-by: Tam Mach <sayboras@yahoo.com>
Signed-off-by: Paul Chaignon <paul@cilium.io>
[ upstream commit bb615ea ]

The name of the policy call map on the bpffs was changed between 1.7 and
1.8 by commit 5d6b669. Commit 6bada02 then added code to delete the old
map name on initialization of the agent.

We cannot simply delete the old policy call map because it might still
be used by endpoints (until they are regenerated) and the base programs
(until they are reloaded). However, if we rename the map in the bpffs,
it shouldn't affect BPF programs that are using it and they will then
pick up the new name on reload.

The reverse renaming operation is needed in 1.7 to allow for downgrades
from 1.8.

Fixes: 5d6b669 ("maps/policymap: Rename policy call map to clarify intent")
Fixes: 6bada02 ("daemon: Remove old policy call map")
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno requested a review from a team as a code owner September 7, 2020 09:24
@pchaigno pchaigno added backport/1.8 kind/backports This PR provides functionality previously merged into master. labels Sep 7, 2020
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for my changes 💯

@aanm aanm merged commit 3f7b327 into v1.8 Sep 9, 2020
@aanm aanm deleted the pr/v1.8-backport-2020-09-07 branch September 9, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/backports This PR provides functionality previously merged into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants