Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DNS poller #13229

Merged
merged 4 commits into from
Sep 22, 2020
Merged

Remove DNS poller #13229

merged 4 commits into from
Sep 22, 2020

Conversation

tklauser
Copy link
Member

The DNS Poller was deprecated in v1.8 by #10629 and announced to be
removed in v1.9. Remove it now.

Fixes: #8604

Remove DNS poller after being deprecated in Cilium 1.8.

@tklauser
daemon, option, test: remove DNS poller options
7c58e45 
The actual functionality will be removed in successive commits.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser
daemon, fqdn: remove DNS poller implementation
a7d8891 
The DNS Poller was deprecated in v1.8 in #10629 and announced to be
removed in v1.9. Remove it now.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser requested a review from a team September 21, 2020 09:14
@tklauser tklauser requested review from a team as code owners September 21, 2020 09:14
@tklauser tklauser requested a review from a team September 21, 2020 09:14
@tklauser tklauser requested a review from a team as a code owner September 21, 2020 09:14
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 21, 2020
@tklauser tklauser added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Sep 21, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 21, 2020
@tklauser
Copy link
Member Author

test-me-please

@tklauser
test: fix runtime tests after removal of DNS poller
ba9e30c 
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser
proxy/accesslog: remove DNSSourceAgentPoller
62d5231 
This DNS data source type is no longer used after the DNS poller was
removed. Remove it as well.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser
Copy link
Member Author

test-focus RuntimeFQDN*

@tklauser
Copy link
Member Author

test-me-please

@tklauser
Copy link
Member Author

tklauser commented Sep 21, 2020 •
edited
Loading

retest-net-next

EDIT: hit #13224 https://jenkins.cilium.io/job/Cilium-PR-K8s-1.12-net-next/530/

@tklauser tklauser mentioned this pull request Sep 21, 2020
Closed
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 22, 2020
@qmonnet qmonnet merged commit 029e750 into master Sep 22, 2020
@qmonnet qmonnet deleted the pr/tklauser/remove-dns-poller branch September 22, 2020 08:04
@tklauser tklauser mentioned this pull request Sep 22, 2020
Merged
tklauser added a commit that referenced this pull request Oct 2, 2020
@tklauser
test: update runtime test descriptions after removal of DNS poller
4ca0c13 
Follow-up for #13229

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser mentioned this pull request Oct 2, 2020
Merged
aanm pushed a commit that referenced this pull request Oct 5, 2020
@tklauser @aanm
test: update runtime test descriptions after removal of DNS poller
31c3bab 
Follow-up for #13229

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@joestringer joestringer mentioned this pull request Oct 12, 2020
Merged
tklauser added a commit that referenced this pull request Oct 13, 2020
@tklauser
fqdn: remove remnants godoc comments mentioning DNS poller
d191c14 
Follow-up for #13229 which removed the DNS poller implementation.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser mentioned this pull request Oct 13, 2020
Merged
aanm pushed a commit that referenced this pull request Oct 13, 2020
@tklauser @aanm
fqdn: remove remnants godoc comments mentioning DNS poller
0d4c4b6 
Follow-up for #13229 which removed the DNS poller implementation.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser added a commit that referenced this pull request Jan 12, 2021
@tklauser
api: remove unused DNSPollNames property
c2e77cd 
Support for DNS poller was removed in PR #13229 and the field is no
longer set since commit 5590bf4 ("fqdn: remove unused
(*NameManager).GetDNSNames and related fields"). Remove it before we
eventually declare the API stable.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser mentioned this pull request Jan 12, 2021
Merged
aanm pushed a commit that referenced this pull request Jan 14, 2021
@tklauser @aanm
api: remove unused DNSPollNames property
14bb372 
Support for DNS poller was removed in PR #13229 and the field is no
longer set since commit 5590bf4 ("fqdn: remove unused
(*NameManager).GetDNSNames and related fields"). Remove it before we
eventually declare the API stable.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@kaworu kaworu kaworu approved these changes

@ianvernon ianvernon ianvernon approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate DNS Poller in v1.8, remove in v1.9
6 participants
@tklauser @gandro @kaworu @ianvernon @aanm @qmonnet