Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove two unused OpenAPI properties #14590

Merged
merged 2 commits into from
Jan 14, 2021
Merged

Remove two unused OpenAPI properties #14590

merged 2 commits into from
Jan 14, 2021

Conversation

tklauser
Copy link
Member

The container runtime status property is no longer set by the daemon since commit 532ad9d. Support for DNS poller was removed in PR #13229 and the respective property is no longer set since commit 5590bf4.

Remove these properties before eventually declaring the API stable.

Remove the unused container runtime status and DNS poller names properties from Cilium API.

@tklauser
api: remove unused container runtime status from StatusResponse
76e6195 
This field is no longer set by the daemon since commit 532ad9d ("rm
pkg/workloads"), so drop it before we eventually declare the API stable.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser
api: remove unused DNSPollNames property
c2e77cd 
Support for DNS poller was removed in PR #13229 and the field is no
longer set since commit 5590bf4 ("fqdn: remove unused
(*NameManager).GetDNSNames and related fields"). Remove it before we
eventually declare the API stable.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser added kind/cleanup This includes no functional changes. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Jan 12, 2021
@tklauser tklauser requested review from tgraf, aanm and a team January 12, 2021 09:55
@tklauser tklauser requested review from a team as code owners January 12, 2021 09:55
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Jan 12, 2021
@tklauser
Copy link
Member Author

test-me-please

@tklauser
Copy link
Member Author

tklauser commented Jan 12, 2021 •
edited

retest-net-next

https://jenkins.cilium.io/view/PR/job/Cilium-PR-K8s-1.13-net-next/410/ looks like #13275

@qmonnet
Copy link
Member

qmonnet commented Jan 12, 2021

test-gke

@qmonnet qmonnet removed their assignment Jan 12, 2021
@tklauser
Copy link
Member Author

tklauser commented Jan 13, 2021 •
edited

retest-net-next

Hit #13833 #14598 (https://jenkins.cilium.io/job/Cilium-PR-K8s-1.13-net-next/418/)

@tklauser
Copy link
Member Author

tklauser commented Jan 13, 2021 •
edited

retest-net-next

Hit #12511 https://jenkins.cilium.io/job/Cilium-PR-K8s-1.13-net-next/426/

@aanm aanm merged commit 14bb372 into master Jan 14, 2021
@aanm aanm deleted the pr/tklauser/api-remove-unused branch January 14, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@qmonnet qmonnet qmonnet approved these changes

@tgraf tgraf Awaiting requested review from tgraf

@errordeveloper errordeveloper Awaiting requested review from errordeveloper

Assignees

@errordeveloper errordeveloper

@tgraf tgraf

@aanm aanm

Labels
kind/cleanup This includes no functional changes. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tklauser @qmonnet @aanm @errordeveloper @tgraf