test: enable hubble tls in ci #13232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaworu
added
release-note/misc
rolinh
approved these changes
Sep 21, 2020
gandro
reviewed
Sep 21, 2020
kaworu
force-pushed
the
pr/kaworu/enable-hubble-tls-in-ci
branch
from
fdd057a
to
092c0cd
Compare
|
test-me-please |
gandro
approved these changes
Sep 21, 2020
christarazi
requested changes
Sep 21, 2020
kaworu
force-pushed
the
pr/kaworu/enable-hubble-tls-in-ci
branch
from
092c0cd
to
eaf1a7b
Compare
Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
|
test-me-please |
christarazi
approved these changes
Sep 22, 2020
| expected := string(res.GetStdOut().Bytes()) | ||
|
|
||
| serverName := fmt.Sprintf("%s.default.hubble-grpc.cilium.io", helpers.K8s1) | ||
| cmd := helpers.OpenSSLShowCerts("localhost", defaults.ServerPort, serverName) |
There was a problem hiding this comment.
I think this is a nice change as well!
Comment on lines
+176
to
+180
| // ReadFile returns the string representing a cat command to read the file at | ||
| // the give path. | ||
| func ReadFile(path string) string { | ||
| return fmt.Sprintf("cat %q", path) | ||
| } |
There was a problem hiding this comment.
Thanks for adding the helpers!
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable TLS for Hubble and verify that the expected certificate is served.