v1.8 backports 2020-10-02-2 #13388
Merged
v1.8 backports 2020-10-02-2 #13388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit 0b8148b ] Previously, the observer implementation assumed time range filters on the request are not compatible with follow-mode. This however is no longer the case, we can now apply the since filter when rewinding the ring buffer. This means that if the user specifies a `since` timestamp, we first dump all flows newer than `since` before we enter follow-mode. Fixes: cilium/hubble#363 Signed-off-by: Sebastian Wicki <sebastian@isovalent.com> Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
rolinh
added
kind/backports
|
test-backport-1.8 |
|
retest-4.19 |
gandro
approved these changes
Oct 5, 2020
|
CI was all green, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--sincerequests in combination with follow-mode #13324 -- hubble: Support--sincerequests in combination with follow-mode (@gandro)@gandro There was a conflict in the tests due to the changes brought by #12712. I updated the test to use
flowspb.Payloadinstead ofobserverTypes.MonitorEventfor thegenerateFlowschan. PTAL.Once this PR is merged, you can update the PR labels via: