hubble: Support --since requests in combination with follow-mode
#13324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandro
added
release-note/bug
This comment has been minimized.
This comment has been minimized.
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
gandro
force-pushed
the
pr/gandro/hubble-follow-with-since
branch
from
166dd04
to
949ecd5
Compare
This comment has been minimized.
This comment has been minimized.
gandro
force-pushed
the
pr/gandro/hubble-follow-with-since
branch
from
949ecd5
to
7628787
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
rolinh
approved these changes
Sep 29, 2020
|
test-me-please |
glibsm
reviewed
Sep 29, 2020
maintainer-s-little-helper
bot
added
the
ready-to-merge
glibsm
approved these changes
Sep 29, 2020
gandro
force-pushed
the
pr/gandro/hubble-follow-with-since
branch
from
7628787
to
4abcbc4
Compare
gandro
removed
the
ready-to-merge
Previously, the observer implementation assumed time range filters on the request are not compatible with follow-mode. This however is no longer the case, we can now apply the since filter when rewinding the ring buffer. This means that if the user specifies a `since` timestamp, we first dump all flows newer than `since` before we enter follow-mode. Fixes: cilium/hubble#363 Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
force-pushed
the
pr/gandro/hubble-follow-with-since
branch
from
4abcbc4
to
5277eb8
Compare
|
test-me-please |
christarazi
approved these changes
Sep 29, 2020
There was a problem hiding this comment.
net-next hit #13062. All other tests have passed and have all code owner approval. Merging.
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.4
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Needs backport from master
in 1.8.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the observer implementation assumed time range filters on
the request are not compatible with follow-mode. This however is no
longer the case, we can now apply the since filter when rewinding the
ring buffer. This means that if the user specifies a
sincetimestamp,we first dump all flows newer than
sincebefore we enter follow-mode.Fixes: cilium/hubble#363