-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: docker: update some command outputs #13695
Conversation
Proxy Status: OK, ip 10.15.66.191, 0 redirects active on ports 10000-20000 | ||
Cluster health: 0/1 reachable (2020-10-22T09:54:59Z) | ||
Name IP Reachable Endpoints reachable | ||
vagrant (localhost) 10.0.2.15 true false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should become reachable
after a while.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, and look something like:
Cluster health: 4/4 reachable (2020-10-22T10:59:19Z)
Also, it looks like Hubble status was removed. With 1.9 enabling Hubble by default, it should actually look something like this:
Hubble: Ok Current/Max Flows: 4096/4096 (100.0%), Flows/s: 1.29 Metrics: Disabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, I should have waited a few seconds more to see that endpoint in a reachable
state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This made me realize that the Vagrantfile
for that tutorial is still using a docker image for cilium based on version 1.7
.
I bumped it in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jibi How come Hubble is marked as "Disabled"? It should be enabled by default as stated in my comment above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect it's because we are not pulling the hubble images in the docker-compose.yml file (although I have still not much context on how the docker setup works for hubble)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting with Cilium 1.8, Hubble server is embedded in Cilium so not extra image is required. Actually, the reason why it does not show up is because the Cilium version is 1.7.2 as you found out in #13697. I think that the command output should be updated for v1.9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the command output should be updated for v1.9.
I actually had already updated the image before running that command 🤔
vagrant@vagrant:~/cilium/examples/getting-started$ cilium version
Client: 1.9.0-rc2 fae41eead 2020-10-21T21:03:17+11:00 go version go1.15.3 linux/amd64
Daemon: 1.9.0-rc2 fae41eead 2020-10-21T21:03:17+11:00 go version go1.15.3 linux/amd64
vagrant@vagrant:~/cilium/examples/getting-started$ cilium status | grep Hubble
Hubble: Disabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmh, not sure why Hubble is disabled then 🤔 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth opening an issue? Sounds like Docker integration is best effort (no large users).
This PR addresses a couple of small nits in the
docker
getting started guide (just updating the output of some commands to make the document consistent with the current revision of cilium)