[1.9] Disable checkpatch github action on release branch

[tklauser]

checkpatch consistent fails on backport PRs due to the formatting of the
upstream commit, see e.g. [1]. Since we expect changes to go through
master first where checkpatch is run and need to pass before merge,
disable the check on the 1.9 release branch.

[1] https://github.com/cilium/cilium/pull/13903/checks?check_run_id=1357642875

[qmonnet]

Thanks! I noticed that as well and I have a PR (locally) for image-tools to remove GIT_COMMIT_ID from the list of reported issues, this would fix those false positives. I just never finished and pushed it but I'll do it now. Would that be an acceptable fix?

Note that I'm also fine if we remove checkpatch for release branches, since your rational is correct and backport have already been through the checks on the main branch.

[qmonnet]

See cilium/image-tools#85 (and this commit in particular) (this will require an additional PR in Cilium to update the tag of the checkpatch image we use).

[tklauser]

Thanks! I noticed that as well and I have a PR (locally) for image-tools to remove GIT_COMMIT_ID from the list of reported issues, this would fix those false positives. I just never finished and pushed it but I'll do it now. Would that be an acceptable fix?

Thanks, I'd say fixing this for checkpatch in image-tools is probably the better way forward, as it won't require disabling the GH action in future release branches manually.

Note that I'm also fine if we remove checkpatch for release branches, since your rational is correct and backport have already been through the checks on the main branch.

I'm fine to close this PR and backport an update to the new checkpatch version once cilium/image-tools#85 is merged and updated in cilium/cilium.