Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkpatch: update image tag to latest #13976

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

qmonnet
Copy link
Member

@qmonnet qmonnet commented Nov 10, 2020

Update the tag for the checkpatch image in order to benefit from the latest changes when running the GitHub action:

  • Fix and update the issues reported by checkpatch. In particular, ignoring GIT_COMMIT_ID reports will avoid automatic checkpatch failures for backports.
  • Allow for passing arguments directly to checkpatch.pl (not just the bash script), such as --fix-inplace.

See cilium/image-tools#85.
Addresses follow-up items for #12467.
Related: #13904.

Update the tag for the checkpatch image in order to benefit from the
latest changes when running the GitHub action:

- Fix and update the issues reported by checkpatch.
- Allow for passing arguments directly to checkpatch.pl (not just the
  bash script), such as --fix-inplace.

See cilium/image-tools#85.

Signed-off-by: Quentin Monnet <quentin@isovalent.com>
@qmonnet qmonnet added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. labels Nov 10, 2020
@qmonnet qmonnet requested a review from a team as a code owner November 10, 2020 16:55
@qmonnet qmonnet requested a review from kkourt November 10, 2020 16:55
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Nov 10, 2020
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. FWIW, I've also marked this to be backported to 1.9.

@tklauser
Copy link
Member

No need to run Jenkins CI, marking as ready to merge.

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 11, 2020
@aanm aanm merged commit 3ca315d into cilium:master Nov 11, 2020
@qmonnet qmonnet deleted the pr/qmonnet/checkpatch_tag_update branch November 11, 2020 11:01
@joestringer joestringer added this to Backport pending to v1.9 in 1.9.1 Nov 17, 2020
@aanm aanm mentioned this pull request Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.9.1
Backport pending to v1.9
Development

Successfully merging this pull request may close these issues.

None yet

7 participants