Add Registry Credentials to Tests #13959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanjsweet
added
area/CI
nathanjsweet
force-pushed
the
pr/nathanjsweet/add-registry-creds-to-tests
branch
from
8260680
to
cdc92f1
Compare
nebril
requested changes
Nov 10, 2020
nathanjsweet
force-pushed
the
pr/nathanjsweet/add-registry-creds-to-tests
branch
3 times, most recently
from
4db6695
to
7b846fd
Compare
|
test-me-please |
|
Also, I believe backporting to older branches will have a slight gotcha where the Helm option for |
|
@christarazi good catch. I'll make sure to do the backport myself, once this gets merged. |
nathanjsweet
force-pushed
the
pr/nathanjsweet/add-registry-creds-to-tests
branch
from
7b846fd
to
0263ab0
Compare
|
test-me-please |
aanm
approved these changes
Nov 11, 2020
|
Builds was green, I'm re-trigerring to see if this PR helps with the current rate limiting. |
tklauser
requested changes
Nov 11, 2020
There was a problem hiding this comment.
One small nit on the commit message format: could you please add an empty line after the commit's subject? i.e.
Add Registry Credentials to Tests
In order to get around image registry pull limits,
credentials can be set.
This will make it easier to backport the commit, as otherwise our git grep magic in the backport scripts doesn't seem to find commits formatted like this.
nebril
approved these changes
Nov 12, 2020
This was referenced Nov 12, 2020
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.6
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.12
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.12
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Backport done to v1.7
in 1.7.12
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Backport done to v1.7
in 1.7.12
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.6
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.6
This was referenced Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get around image registry pull limits,
credentials can be set.
Signed-off-by: Nate Sweet nathanjsweet@pm.me