Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.8 backports 2020-11-12 #14009

Merged
merged 1 commit into from
Nov 12, 2020
Merged

v1.8 backports 2020-11-12 #14009

merged 1 commit into from
Nov 12, 2020

Conversation

nathanjsweet
Copy link
Member

@nathanjsweet nathanjsweet commented Nov 12, 2020 •
edited by aanm

Once this PR is merged, you can update the PR labels via:

$ for pr in 13959; do contrib/backporting/set-labels.py $pr done 1.8; done

@nathanjsweet
Add Registry Credentials to Tests
53d4dfa 
[ upstream commit e8605f8 ]

In order to get around image registry pull limits,
credentials can be set.

Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
@nathanjsweet nathanjsweet added kind/backports This PR provides functionality previously merged into master. backport/1.8 labels Nov 12, 2020
@nathanjsweet nathanjsweet requested a review from a team as a code owner November 12, 2020 16:20
@nathanjsweet
Copy link
Member Author

test-backport-1.8

fristonio
fristonio approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@fristonio fristonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 12, 2020
@fristonio fristonio merged commit 4a9ca20 into v1.8 Nov 12, 2020
@fristonio fristonio deleted the pr/v1.8-backport-2020-11-12 branch November 12, 2020 22:06
@aanm aanm mentioned this pull request Dec 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christarazi christarazi christarazi approved these changes

@fristonio fristonio fristonio approved these changes

Assignees

@fristonio fristonio

Labels
kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nathanjsweet @christarazi @fristonio