test: Use NFS by default in test VMs #13983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
area/CI
pchaigno
force-pushed
the
pr/pchaigno/nfs-in-ci
branch
from
1296bbd
to
c8beae3
Compare
pchaigno
force-pushed
the
pr/pchaigno/nfs-in-ci
branch
from
c8beae3
to
5349fe4
Compare
pchaigno
changed the title
|
test-runtime |
pchaigno
force-pushed
the
pr/pchaigno/nfs-in-ci
branch
from
5349fe4
to
6f07830
Compare
brb
approved these changes
Nov 26, 2020
pchaigno
force-pushed
the
pr/pchaigno/nfs-in-ci
branch
from
6f07830
to
b8a22a5
Compare
|
Note: I've disabled NFS for the Runtime test VM because it leads to permission errors. I will try to debug and re-enable later. |
The new K8sVerifier test compiles some Cilium binaries inside the VM, which can lead to 'interrupted system call' errors. Using NFS should fix it by speeding up the filesystem accesses. This commit switches the test VMs to use NFS by default, thereby enabling NFS in our CI. NFS remains disabled in the CI's Runtime tests because it leads to permission errors [1]. 1 - https://jenkins.cilium.io/job/Cilium-PR-Runtime-4.9/2739/consoleFull Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
pr/pchaigno/nfs-in-ci
branch
from
b8a22a5
to
afae509
Compare
aanm
approved these changes
Nov 26, 2020
nebril
approved these changes
Nov 26, 2020
maintainer-s-little-helper
bot
added
the
ready-to-merge
errordeveloper
approved these changes
Nov 27, 2020
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.1
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.1
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.1
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.1
|
Backporting this to v1.8 as we will otherwise likely hit interrupted system call errors in the K8sVerifier test (already hitting those when running it locally). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new K8sVerifier test compiles some Cilium binaries inside the VM, which can lead to
interrupted system callerrors. Using NFS should fix it by speeding up the filesystem accesses.This pull request switches the test VMs to use NFS by default, thereby enabling NFS in our CI.