Prepare for release v1.8.7 #15017
Merged
Prepare for release v1.8.7 #15017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
backport/1.8
kind/backports
joestringer
added
backport/1.8
kind/release
joestringer
commented
Feb 17, 2021
| @@ -34,7 +34,7 @@ const ( | |||
| // | |||
| // Maintainers: Run ./Documentation/check-crd-compat-table.sh for each release | |||
| // Developers: Bump patch for each change in the CRD schema. | |||
| CustomResourceDefinitionSchemaVersion = "1.21.2" | |||
| CustomResourceDefinitionSchemaVersion = "1.21.3" | |||
There was a problem hiding this comment.
For this, I just ran check-compat-tables.h and did what it said without thought:
$ Documentation/check-crd-compat-ta
ble.sh v1.8
Current version for branch v1.8 should be 1.21.3, not 1.21.2, please run the following command to fix it:
git checkout origin/v1.8 && \
sed -i 's+1.21.2+1.21.3+' pkg/k8s/apis/cilium.io/v2/register.go
But I think this always increments for every release..? Is that intended @aanm ?
If not, how does someone actually know if the CRD changes? Are there specific file paths we are supposed to pay attention to?
There was a problem hiding this comment.
I don't think we want to increment the version. Last release I had the same issue and Andre mentioned to ignore it for now until it's fixed.
There was a problem hiding this comment.
Yeah if CRDs were not changed then we shouldn't increment this version
pchaigno
reviewed
Feb 17, 2021
christarazi
approved these changes
Feb 17, 2021
joestringer
force-pushed
the
pr/prepare-v1.8.7
branch
from
2606949
to
e2cbc8f
Compare
Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
force-pushed
the
pr/prepare-v1.8.7
branch
from
e2cbc8f
to
ae05a55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Minor Changes:
Bugfixes:
when the sender sets the "don't fragment" (DF) bit. (Backport PR v1.8 backports 2021-01-26 #14740, Upstream PR pkg/node: Skip setting MTU on local node routes #14679, @aditighag)
k8s_event_lag_secondsmetric. (Backport PR v1.8 backports 2020-12-17 #14441, Upstream PR pkg/k8s: fix k8s_event_lag_seconds for negative time #14313, @aanm)Fix IPv6 connectivity to BPF HostPort when kube-proxy is installed (Backport PR v1.8 backports 2021-02-12 #14953, Upstream PR bpf: Do not bypass conntrack if running kube-proxy+vxlan+endpoint routes #14675, @pchaigno)
CI Changes:
Misc Changes:
Other Changes: