helm: 'bpf.ctTcpMax' and 'bpf.ctAnyMax' need to be strings, not integers

[mvisonneau]

Make it more evident for end users by amending the comment regarding how to configure bpf.ctTcpMax and bpf.ctAnyMax

Helm release would succeed if integers are provided but the Cilium agents would then crash.

[aanm]

Can you clarify why lbMapMax does not require the integer to be quoted for example?

[mvisonneau]

Can you clarify why lbMapMax does not require the integer to be quoted for example?

actually it could be related to using | quote ctAnyMax vs {{ }} lbMapMax

I will give it a try

[mvisonneau]

indeed:

-   bpf-ct-global-tcp-max: "2097152"
-   bpf-ct-global-any-max: "1048576"
+   bpf-ct-global-tcp-max: "2.097152e+06"
+   bpf-ct-global-any-max: "1.048576e+06"

I assume that the agent is not happy about the scientific notation. Could be related to the coalesce function rather than the quoting part though.

[aanm]

So for consistency we should quote all numbers? @mvisonneau

[mvisonneau]

I tried to find a way to update the chart templating logic to be able to leverage numbers but I did not manage to get it to work yet. I believe that it would be interesting to stick to the actually expected type by default but at the same time, current implementation prevents it. Lets perhaps merge this one and create a follow-up issue to figure out what to do with this problem 🤔

[joestringer]

@aanm what do you think of @mvisonneau 's proposal above? If we're fine to merge this as-is, it will need a rebase.

[aanm]

@joestringer LGTM

[joestringer]

👍 just needs to be rebased.

[mvisonneau]

rebased! 👍

[kaworu]

Helm doc failure from the CI pipeline is legit, @mvisonneau please run make -C install/kubernetes docs.

[mvisonneau]

ah right! I rebased again and ran the formatting command 👍, sorry about that

[kaworu]

[EDIT: deleted - sorry, missclick]

[kaworu]

@mvisonneau Thanks! Marking this as ready-to-merge as it doesn't warrant a full CI run.