-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.dockerignore: add *.box files #14045
Conversation
By default, `test/packet/scripts/add_vagrant_box.sh` uses `.` as the destination directory which might lead to large `*.box` files in the cilium source directory. Instruct docker to ignore these files. Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
While you're at it, would you mind adding a
This should not be ignored but is currently marked to be ignored with the global |
By default, the add_vagrant_box.sh script used to download Vagrant boxes to the current directory. This can lead to issues when the current directory is Cilium's [1]. This commit removes the -t flag to download to /tmp and makes that the default. Now, if -t is given, it will display a warning. This commit also introduces a new -d <dir> flag to download the Vagrant boxes to a directory different from /tmp. 1 - #14045 Signed-off-by: Paul Chaignon <paul@cilium.io>
By default, the add_vagrant_box.sh script used to download Vagrant boxes to the current directory. This can lead to issues when the current directory is Cilium's [1]. This commit removes the -t flag to download to /tmp and makes that the default. Now, if -t is given, it will display a warning. This commit also introduces a new -d <dir> flag to download the Vagrant boxes to a directory different from /tmp. 1 - #14045 Signed-off-by: Paul Chaignon <paul@cilium.io>
By default,
test/packet/scripts/add_vagrant_box.sh
uses.
as thedestination directory which might lead to large
*.box
files in thecilium source directory. Instruct docker to ignore these files.
Signed-off-by: Kornilios Kourtis kornilios@isovalent.com