test/packet: Default download to /tmp #14055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
the
release-note/misc
qmonnet
reviewed
Nov 17, 2020
By default, the add_vagrant_box.sh script used to download Vagrant boxes to the current directory. This can lead to issues when the current directory is Cilium's [1]. This commit removes the -t flag to download to /tmp and makes that the default. Now, if -t is given, it will display a warning. This commit also introduces a new -d <dir> flag to download the Vagrant boxes to a directory different from /tmp. 1 - #14045 Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
pr/pchaigno/download-vagrant-default-tmp
branch
from
fdd180e
to
a65a05e
Compare
aanm
approved these changes
Nov 17, 2020
kkourt
approved these changes
Nov 17, 2020
nebril
approved these changes
Nov 17, 2020
pchaigno
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the
add_vagrant_box.shscript used to download Vagrant boxes to the current directory. This can lead to issues when the current directory is Cilium's.This pull request removes the
-tflag to download to/tmpand makes that the default. Now, if-tis given, it will display a warning. This pull request also introduces a new-d <dir>flag to download the Vagrant boxes to a directory different from/tmp.