policy: limit the number of L4 ports to 40 #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianvernon
reviewed
Sep 1, 2017
Documentation/policy.rst
Outdated
| @@ -324,6 +324,9 @@ The ``toPorts`` field takes a ``PortProtocol`` structure which is defined as fol | |||
| Protocol string `json:"protocol,omitempty"` | |||
| } | |||
|
|
|||
| .. note:: There is currently a max limit of 40 ports. This might change in the | |||
| future when support for ranges are added. | |||
tests/11-getting-started.sh
Outdated
| @@ -27,7 +26,7 @@ echo "------ checking cilium status ------" | |||
| cilium status | |||
|
|
|||
| echo "------ creating Docker network of type Cilium ------" | |||
There was a problem hiding this comment.
Remove the echo statements prior to the calls to this helper function as the echo statement is already part of the helper function.
There was a problem hiding this comment.
Was actually done earlier but probably pushed from the wrong machine. Should be gone now.
Also updated policy import test with check for ingress but the validation is performed on the `PortRule` so works for egress as well. Closes: #922 (L4 policy with more than 40 ports doesn't work) Signed-off-by: Alexander Alemayhu <alexander@alemayhu.com>
Valid json is not enough to detect all syntax errors, f. ex. when
using {to,from}CIDR.
Signed-off-by: Alexander Alemayhu <alexander@alemayhu.com>
This fixes some local failures I have seen when running `16-cidr-ingress-policy`.
aanm
approved these changes
Sep 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #922 (L4 policy with more than 40 ports doesn't work)