v1.9 backports 2020-11-23 #14139
Merged
v1.9 backports 2020-11-23 #14139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit b8a9c79 ] This should allow external sites to better represent Cilium in artifacts generated from the Helm charts. Signed-off-by: Joe Stringer <joe@cilium.io>
[ upstream commit 476133a ] Expand the charts to include other common fields so that external systems can pull & use icons, tags, k8s version support, etc. Furthermore, flesh out the readme so it renders better. While we're at it, add an SVG without the cilium word so that it's more likely to render correctly in a square on external sites. Signed-off-by: Joe Stringer <joe@cilium.io>
[ upstream commit 3f0b81a ] These mostly needed '--' at the start for the helm-docs container to pick up the descriptions and render them into the README.md. While we're at it, Remove stuttering via the old go style of typing the variable at the start of the sentence, use full sentences, and remove any comments that were named exactly the same as the variable. Signed-off-by: Joe Stringer <joe@cilium.io>
[ upstream commit e2b3707 ] This was not referenced anywhere else, remove it. Signed-off-by: Joe Stringer <joe@cilium.io>
[ upstream commit 25f45b5 ] This option was too specific and doesn't make sense to expose as a user-visible flag in the helm charts. Remove it. Signed-off-by: Joe Stringer <joe@cilium.io>
[ upstream commit cb98323 ] Artifact Hub suggests that if we add such annotations to our charts, then they will show up in the Artifact Hub UI somewhere: https://artifacthub.io/docs/topics/annotations/helm/ Signed-off-by: Joe Stringer <joe@cilium.io>
[ upstream commit e363b4a ] v1.10 will need more than the first 3 digits of the version semver, it will need the full $major.$minor. Fix this up. Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
added
backport/1.9
kind/backports
[ upstream commit ad865cd ] Signed-off-by: Joe Stringer <joe@cilium.io>
[ upstream commit 0611e22 ] Signed-off-by: Chris Tarazi <chris@isovalent.com> Signed-off-by: Joe Stringer <joe@cilium.io>
[ upstream commit 3631267 ] Now that cilium/cilium-sysdump#96 has been merged, we no longer have a 30m default for --since. Instead, cilium-sysdump will no longer have time-based default limits; it will default to collecting the entire history. Signed-off-by: Chris Tarazi <chris@isovalent.com> Signed-off-by: Joe Stringer <joe@cilium.io>
[ upstream commit 0d578a8 ] This commit clarifies the cilium-sysdump methods of limiting the size of the sysdump to ensure the user is aware of the most effective approach. Signed-off-by: Chris Tarazi <chris@isovalent.com> Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
force-pushed
the
pr/v1.9-backport-2020-11-23
branch
from
fafcdaa
to
6a2557f
Compare
|
test-backport-1.9 |
errordeveloper
approved these changes
Nov 24, 2020
|
@joestringer would you entertain the possibility of including #14134 also? |
|
@errordeveloper makes sense to backport that, we can roll that PR into the next round of backports. |
|
Hit GKE infrastructure issue: https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/3373/ |
|
retest-gke EDIT: Infrastructure issues: https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/3381/ |
|
retest-gke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, you can update the PR labels via: