-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete kube-router documentation #14161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Maybe this should be merged to the paragraph above, so that the relevant configuration can also be added to the example snippet? That would make it easier for users to copy both options at once to update their ConfigMap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @qmonnet , I think it's pretty important for getting started guides to have a ready-to-copy snippets.
thanks, yes, that's a good point. Let me change that |
BUG: #14152 Kube-router fetches the CIDRs from Kubernetes and thus ipam: cluter-pool configuration does not really work well. This patch clarifies this in the kube-router documentation Signed-off-by: Manuel Buil <mbuil@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change, looks all good to me now :)
Conformance test failures seem related to cilium/cilium-sysdump#100. The generate-api
test failed because quay.io is currently down.
Kube-router fetches the CIDRs from Kubernetes and thus ipam: cluter-pool
configuration does not really work well. This patch clarifies this in
the kube-router documentation
Signed-off-by: Manuel Buil mbuil@suse.com
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.
Fixes: #14152