Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete kube-router documentation #14161

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Complete kube-router documentation #14161

merged 1 commit into from
Nov 27, 2020

Conversation

manuelbuil
Copy link
Contributor

@manuelbuil manuelbuil commented Nov 25, 2020

Kube-router fetches the CIDRs from Kubernetes and thus ipam: cluter-pool
configuration does not really work well. This patch clarifies this in
the kube-router documentation

Signed-off-by: Manuel Buil mbuil@suse.com

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Fixes: #14152

Complete kube-router documentation by mentioning that "ipam: kubernetes" should be used

@manuelbuil manuelbuil requested a review from a team as a code owner November 25, 2020 07:27
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 25, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Nov 25, 2020
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Maybe this should be merged to the paragraph above, so that the relevant configuration can also be added to the example snippet? That would make it easier for users to copy both options at once to update their ConfigMap.

@qmonnet qmonnet requested review from a team and nebril and removed request for a team November 25, 2020 09:22
@qmonnet qmonnet added the release-note/misc This PR makes changes that have no direct user impact. label Nov 25, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 25, 2020
@qmonnet qmonnet added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Nov 25, 2020
Copy link
Member

@nebril nebril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @qmonnet , I think it's pretty important for getting started guides to have a ready-to-copy snippets.

@manuelbuil
Copy link
Contributor Author

thanks, yes, that's a good point. Let me change that

BUG: #14152

Kube-router fetches the CIDRs from Kubernetes and thus ipam: cluter-pool
configuration does not really work well. This patch clarifies this in
the kube-router documentation

Signed-off-by: Manuel Buil <mbuil@suse.com>
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, looks all good to me now :)

Conformance test failures seem related to cilium/cilium-sysdump#100. The generate-api test failed because quay.io is currently down.

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 26, 2020
@errordeveloper errordeveloper merged commit d50075d into cilium:master Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Kube-router and ipam: cluster-pool not working
5 participants