docs: Clarify from/toRequires documentation with a new example #14262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
area/documentation
pchaigno
force-pushed
the
pr/pchaigno/extend-fromtorequires-docs
branch
from
8fde470
to
b2e6299
Compare
joestringer
requested changes
Dec 3, 2020
pchaigno
force-pushed
the
pr/pchaigno/extend-fromtorequires-docs
branch
from
b2e6299
to
61676f4
Compare
joestringer
approved these changes
Dec 3, 2020
qmonnet
approved these changes
Dec 4, 2020
The difference between using toRequires+toEndpoints vs. toEndpoints+toEndpoints (i.e., first is logical AND of the rules whereas second is OR) is not particularly obvious when first reading the toRequires documentation. This commit attempts to clarify this difference by completing the fromRequires example with a fromEndpoints policy. Suggested-by: Thomas Graf <thomas@cilium.io> Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
pr/pchaigno/extend-fromtorequires-docs
branch
from
61676f4
to
c4bef71
Compare
|
Rebased with a minor change to address Quentin's nit. Marking as ready to merge. |
pchaigno
added
the
ready-to-merge
joestringer
moved this from Needs backport from master
to Backport done to v1.8
in 1.8.7
joestringer
moved this from Needs backport from master
to Backport done to v1.9
in 1.9.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The difference between using
toRequires+toEndpointsvs.toEndpoints+toEndpoints(i.e., first is logical AND of the rules, whereas the second is OR) is not particularly obvious when first reading thetoRequiresdocumentation.This pull request attempts to clarify this difference by completing the
fromRequiresexample with afromEndpointspolicy.