test: Add missing gomega Eventually intervals #14388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gomega time interval between Eventually retries is 10ms. Use 1 second to clean up the test logs like these: ... 15:31:27 23:31:26 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready 15:31:27 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready 15:31:27 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready 15:31:27 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready 15:31:27 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready 15:31:27 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready 15:31:27 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready 15:31:27 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready 15:31:28 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready 15:31:28 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready 15:31:28 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready 15:31:28 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready 15:31:28 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready 15:31:28 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready 15:31:28 23:31:28 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready 15:31:28 23:31:28 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready ... Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
jrajahalme
added
kind/enhancement
|
test-me-please |
|
Please see #14384. Is there any benefit to printing the message in the first place? |
kaworu
approved these changes
Dec 14, 2020
aanm
approved these changes
Dec 14, 2020
christarazi
reviewed
Dec 14, 2020
There was a problem hiding this comment.
I agree with @pchaigno. These msgs aren't of any value. We can still print a msg when it fails. Either way, we can either do it as a followup or in this PR.
|
I've added labels for backports into v1.8 and v1.9 given this pull request fixes spam messages introduced by #14286, which was backported to those two branches. |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport done to v1.8
in 1.8.7
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.2
aanm
added
release-note/ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gomega time interval between Eventually retries is 10ms. Use 1 second
to clean up the test logs like these:
...
15:31:27 23:31:26 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready
15:31:27 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready
15:31:27 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready
15:31:27 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready
15:31:27 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready
15:31:27 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready
15:31:27 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready
15:31:27 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready
15:31:28 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready
15:31:28 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready
15:31:28 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready
15:31:28 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready
15:31:28 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready
15:31:28 23:31:27 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready
15:31:28 23:31:28 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready
15:31:28 23:31:28 STEP: Cilium DaemonSet not ready yet: only 1 of 2 desired pods are ready
...
Signed-off-by: Jarno Rajahalme jarno@covalent.io