ipsec: Fatal on unsupported, <4.19 kernels in tunneling mode #14525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
release-note/minor
pchaigno
force-pushed
the
pr/pchaigno/ipsec-fatal-unsupported-kernels
branch
from
bda4591
to
a729ef2
Compare
christarazi
requested changes
Jan 5, 2021
joestringer
approved these changes
Jan 5, 2021
There was a problem hiding this comment.
LGTM, @christarazi pointed out the other aspect of my prior feedback - now the daemon-side check can be simpler.
pchaigno
force-pushed
the
pr/pchaigno/ipsec-fatal-unsupported-kernels
branch
from
a729ef2
to
8ea9a8d
Compare
christarazi
approved these changes
Jan 5, 2021
When using IPSec with Cilium in tunneling mode, we need support for the xfrm state output mask in the kernel (cf. #14381). This commit probes for such kernel support, introduced upstream in 9b42c1f ("xfrm: Extend the output_mark to support input direction and masking"), on startup and fatals if the kernel is too old. The lack of kernel support only breaks policy enforcement across nodes and we can probably make it work in the future, but in the meantime, it's best to cleanly fatal. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
pr/pchaigno/ipsec-fatal-unsupported-kernels
branch
from
8ea9a8d
to
127c0ab
Compare
|
K8s-1.20-kernel-4.9 failed with known flake #13774. Other tests are passing. |
pchaigno
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.7
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.7
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using IPSec with Cilium in tunneling mode, we need support for the xfrm state output mask in the kernel (cf. #14381). This pull request probes for such kernel support, introduced upstream in
9b42c1f("xfrm: Extend the output_mark to support input direction and masking"), on startup and fatals if the kernel is too old.The lack of kernel support only breaks policy enforcement across nodes and we can probably make it work in the future, but in the meantime, it's best to cleanly fatal.