Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: Send packet drop notify for LB DSR mode failures. #14649

Merged
merged 1 commit into from Jan 22, 2021
Merged

bpf: Send packet drop notify for LB DSR mode failures. #14649

merged 1 commit into from Jan 22, 2021

Conversation

hzhou8
Copy link
Contributor

@hzhou8 hzhou8 commented Jan 19, 2021 •
edited

Packets may be dropped silently for errors such as FIB lookup failure
in DSR mode. This patch adds drop notify for all errors in DSR functions.

Signed-off-by: Han Zhou hzhou8@ebay.com

@hzhou8
bpf: Send packet drop notify for LB DSR mode failures.
b805630 
Packets may be dropped silently for errors such as FIB lookup failure
in DSR mode.  This patch adds drop notify for all errors in DSR functions.

Signed-off-by: Han Zhou <hzhou8@ebay.com>
@hzhou8 hzhou8 requested review from a team and jrfastab January 19, 2021 02:10
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 19, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Jan 19, 2021
@hzhou8 hzhou8 mentioned this pull request Jan 19, 2021
Closed
pchaigno
pchaigno approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pchaigno pchaigno added area/monitor Impacts monitoring, access logging, flow logging, visibility of datapath traffic. release-note/misc This PR makes changes that have no direct user impact. labels Jan 19, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 19, 2021
@pchaigno
Copy link
Member

test-me-please

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.2 Jan 19, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.7 Jan 19, 2021
@brb brb added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. sig/loadbalancing and removed needs-backport/1.8 labels Jan 19, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Needs backport from master in 1.9.2 Jan 19, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.7 Jan 19, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Needs backport from master in 1.8.7 Jan 19, 2021
@brb brb added needs-backport/1.8 and removed sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. labels Jan 19, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.2 Jan 19, 2021
@ciliumbot
Copy link

Build finished.

@brb
Copy link
Member

brb commented Jan 20, 2021

test-runtime

@aanm aanm added this to Needs backport from master in 1.9.3 Jan 20, 2021
@aanm aanm removed this from Needs backport from master in 1.9.2 Jan 20, 2021
@aditighag aditighag added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 22, 2021
@rolinh rolinh merged commit 8d575af into cilium:master Jan 22, 2021
@aanm aanm added this to Needs backport from master in 1.9.4 Jan 22, 2021
@aanm aanm removed this from Needs backport from master in 1.9.3 Jan 22, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 25, 2021
@pchaigno pchaigno mentioned this pull request Jan 26, 2021
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.7 Jan 26, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.7 Jan 28, 2021
@joestringer joestringer mentioned this pull request Jan 28, 2021
Merged
@christarazi christarazi moved this from Needs backport from master to Backport done to v1.9 in 1.9.4 Feb 3, 2021
@christarazi christarazi mentioned this pull request Feb 3, 2021
Merged
@joestringer joestringer mentioned this pull request Feb 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkmann borkmann borkmann left review comments

@pchaigno pchaigno pchaigno approved these changes

@aditighag aditighag aditighag approved these changes

@jrfastab jrfastab Awaiting requested review from jrfastab

Assignees

@jrfastab jrfastab

Labels
area/monitor Impacts monitoring, access logging, flow logging, visibility of datapath traffic. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0
Done
1.8.7
Backport done to v1.8
1.9.4
Backport done to v1.9
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@hzhou8 @pchaigno @ciliumbot @brb @borkmann @aditighag @joestringer @jrfastab @rolinh @aanm