-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Added instruction to also delete kube-proxy configmap #14847
Conversation
Commit 0ddb54edb078f7a5d5b982db960603c9ca79066e does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Commits 0ddb54edb078f7a5d5b982db960603c9ca79066e, ac3a342ee506f646d593dede5315049b6b5a66dc do not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
@yoshz Thanks! Could you sign off the commit ( |
@yoshz Thanks for the change. Could you keep the comment saying why the CM deletion is needed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the community! Docs structure LGTM. Please do address @brb's feedback at your convenience.
Commit 91b28a163e494e1dfdd7984c46c78fa2f8775810 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Commit 91b28a163e494e1dfdd7984c46c78fa2f8775810 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
I have added the comment. |
I'm not sure why the bot is still complaining about signoffs, but would you mind squashing the two commits together? Maybe that will help. This page describes how to achieve this: https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git |
Signed-off-by: Yosh de Vos <yosh@elzorro.nl>
Squashed the commits together, hopefully should be fine now. |
This makes sure that kube-proxy is not reinstalled again on kubeadm upgrades from > 1.19.