Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: added --pprof flag/endpoint #14903

Merged
merged 1 commit into from
Feb 14, 2021
Merged

Conversation

mvisonneau
Copy link
Contributor

I believe it could be useful to have it for the operator as well as I was looking to troubleshoot some goroutines.

operator: added --pprof flag/endpoint

@mvisonneau mvisonneau requested a review from a team as a code owner February 9, 2021 10:13
@maintainer-s-little-helper
Copy link

Commit ece3fbc86ab9910bfc9955bdffefc6faa7f8fca8 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Feb 9, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Feb 9, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Feb 9, 2021
@nebril nebril removed their assignment Feb 9, 2021
Copy link
Member

@nebril nebril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but this needs another commit with docs changes:

Run make -C Documentation update-cmdref and commit doc changes made by this script.

@nebril nebril self-assigned this Feb 9, 2021
@mvisonneau
Copy link
Contributor Author

oh right, thanks @nebril, I got the following error when I ran the command though:

~$ make -C Documentation update-cmdref
[..]
Successfully tagged cilium/docs-builder:latest
rm -rf cmdref/cilium*.md
docker container run --rm --workdir /src/Documentation --volume /Users/max/Projects/os/cilium/Documentation/..:/src --env READTHEDOCS_VERSION= --env SKIP_LINT= --user "501:20" cilium/docs-builder ./update-cmdref.sh
./update-cmdref.sh: line 23: /src/bugtool/cilium-bugtool: No such file or directory
make: *** [update-cmdref] Error 127

do you know if I need specific tooling installed beforehand? 🤔

@nebril
Copy link
Member

nebril commented Feb 10, 2021

@mvisonneau you need to build Cilium binaries before running this, sorry for not mentioning that this was also unclear for me. Run
make daemon bugtool operator cilium cilium-health in root of the repo before running make -C Documentation update-cmdref, this will build required binaries. Will make sure that this is better documented too.

#14925 will add docs for that

Signed-off-by: Maxime VISONNEAU <maxime.visonneau@gmail.com>
@mvisonneau
Copy link
Contributor Author

awesome, thanks for the guidance 🙇! I also had to make operator as well and managed to get it done afterwards 👌

@aanm aanm added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Feb 11, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 11, 2021
@nebril
Copy link
Member

nebril commented Feb 12, 2021

test-gke

@joestringer joestringer moved this from Done to In progress in 1.10.0 Feb 12, 2021
@aanm aanm merged commit 9957f5c into cilium:master Feb 14, 2021
1.10.0 automation moved this from In progress to Done Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants