docs: Document update-cmdref make target usage #14925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
pchaigno
approved these changes
Feb 10, 2021
pchaigno
added
release-note/misc
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
pchaigno
added
the
area/documentation
pchaigno
reviewed
Feb 10, 2021
nebril
force-pushed
the
pr/fix-update-cmdref
branch
2 times, most recently
from
05693d0
to
ae0f61d
Compare
qmonnet
reviewed
Feb 10, 2021
There was a problem hiding this comment.
This is CI, more about submitting a change than development itself. Should this go into https://docs.cilium.io/en/latest/contributing/development/contributing_guide/#submitting-a-pull-request instead?
|
@qmonnet good point, will move it to "Submitting a pull request" |
nebril
force-pushed
the
pr/fix-update-cmdref
branch
from
ae0f61d
to
d95a57d
Compare
qmonnet
requested changes
Feb 10, 2021
nebril
force-pushed
the
pr/fix-update-cmdref
branch
2 times, most recently
from
0ed3ce0
to
7e7694b
Compare
qmonnet
requested changes
Feb 11, 2021
This make target needs to be used by contributors who make changes to CLI. Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
nebril
force-pushed
the
pr/fix-update-cmdref
branch
from
7e7694b
to
e553e5f
Compare
qmonnet
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This make target needs to be used by contributors who make changes to
CLI.