Add configurable suffix for operator image repo in helm #14952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nebril
requested review from
a team,
michi-covalent,
qmonnet,
nbusseneau and
christarazi
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
assigned michi-covalent, qmonnet, nbusseneau and christarazi and unassigned nbusseneau
|
test-net-next |
nebril
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
nebril
force-pushed
the
pr/helm-image-suffix
branch
from
baeb9f3
to
48213c8
Compare
|
test-net-next |
aanm
approved these changes
Feb 12, 2021
qmonnet
approved these changes
Feb 12, 2021
sayboras
approved these changes
Feb 12, 2021
Because operator has cloud provider custom suffixes we are not able to add custom suffixes (like `-dev` or `-ci`) for the operator image seamlesly. New operator-specific option allows to do this. Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
This option makes it possible to use new operator.image.suffix Helm value in test runs. Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
nebril
force-pushed
the
pr/helm-image-suffix
branch
from
48213c8
to
3d8ff72
Compare
|
test-4.9 |
christarazi
approved these changes
Feb 12, 2021
nbusseneau
approved these changes
Feb 12, 2021
This was referenced Mar 3, 2021
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.5
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because operator has cloud provider custom suffixes we are not able to add
custom suffixes (like
-devor-ci) for the operator image seamlesly.This change also enables this option to be used in test runs.