Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix ginkgo commands for e2e tests in GKE/EKS #15223

Merged
merged 1 commit into from
Mar 8, 2021
Merged

docs: Fix ginkgo commands for e2e tests in GKE/EKS #15223

merged 1 commit into from
Mar 8, 2021

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Mar 5, 2021 •
edited
Loading

This pull request fixes the ginkgo command used to run end-to-end tests in cloud environments (e.g., GKE or EKS).

Fixes: #14952

@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact. sig/contributing Impacts contribution workflow, guidelines, and tools. labels Mar 5, 2021
@pchaigno pchaigno requested review from a team as code owners March 5, 2021 14:04
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Mar 5, 2021
@pchaigno pchaigno added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Mar 5, 2021
@pchaigno pchaigno requested a review from qmonnet March 5, 2021 14:25
qmonnet
qmonnet approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

@qmonnet qmonnet removed their assignment Mar 5, 2021
@tklauser tklauser removed their assignment Mar 8, 2021
@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 8, 2021
@tklauser
Copy link
Member

tklauser commented Mar 8, 2021

Documentation changes only, no need to run full CI. Marked as ready to merge.

@errordeveloper
Copy link
Contributor

@bpineau looks like this one needs a rebase

@errordeveloper errordeveloper added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Mar 8, 2021
@pchaigno
docs: Fix ginkgo commands for e2e tests in GKE/EKS
920bb96 
This commit fixes the ginkgo command used to run end-to-end tests in
cloud environments (e.g., GKE or EKS).

Fixes: 1141308 ("test: add `ciliu.operator-suffix` cli option")
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Mar 8, 2021
@aanm aanm merged commit fec3c36 into cilium:master Mar 8, 2021
1.10.0 automation moved this from In progress to Done Mar 8, 2021
@pchaigno pchaigno deleted the fix-docs-gingko-cloud-env branch March 8, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/contributing Impacts contribution workflow, guidelines, and tools.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pchaigno @tklauser @errordeveloper @qmonnet @aanm