iptables: Skip CILIUM_TRANSIENT_FORWARD for IPv6 #14994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
sig/datapath
Commit 317a671 ("iptables: Populate CILIUM_FORWARD chain for IPv6") fixed the agent to add IPv6 counterparts to the Cilium IPv4 rules in CILIUM_FORWARD. The same method is however used to install rules in CILIUM_FORWARD and CILIUM_TRANSIENT_FORWARD. The IPv6 chain for CILIUM_TRANSIENT_FORWARD doesn't exist, resulting in the following error message: level=error msg="Command execution failed" cmd="[ip6tables -w 5 -A CILIUM_TRANSIENT_FORWARD -o cilium_host -m comment --comment cilium (transient): any->cluster on cilium_host forward accept -j ACCEPT]" error="exit status 1" subsys=iptables level=warning msg="ip6tables: No chain/target/match by that name." subsys=iptables level=warning msg="failed to install transient iptables rules" error="cannot install forward chain rules to CILIUM_TRANSIENT_FORWARD: exit status 1" subsys=datapath-loader This commit fixes it by skipping the installation of IPv6 rules in CILIUM_TRANSIENT_FORWARD. If we want those rules, more work is required. Fixes: 317a671 ("iptables: Populate CILIUM_FORWARD chain for IPv6") Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
pr/pchaigno/fix-error-ip6tables
branch
from
97fff92
to
5a7ce95
Compare
|
test-me-please |
pchaigno
changed the title
kkourt
approved these changes
Feb 16, 2021
pchaigno
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.5
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.7
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.7
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.7
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 317a671 ("iptables: Populate
CILIUM_FORWARDchain for IPv6") fixed the agent to add IPv6 counterparts to the Cilium IPv4 rules inCILIUM_FORWARD. The same method is however used to install rules inCILIUM_FORWARDandCILIUM_TRANSIENT_FORWARD. The IPv6 chain forCILIUM_TRANSIENT_FORWARDdoesn't exist, resulting in the following error message:This pull request fixes it by skipping the installation of IPv6 rules in
CILIUM_TRANSIENT_FORWARD. If we want those rules, more work is required.Fixes: #14675