ci: add gke workflow #15416
Merged
ci: add gke workflow #15416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
nebril
force-pushed
the
pr/nebril/gke-workflow-migrate-from-cli
branch
from
ebec3df
to
151a164
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
nebril
force-pushed
the
pr/nebril/gke-workflow-migrate-from-cli
branch
from
151a164
to
29c92ef
Compare
nbusseneau
reviewed
Mar 22, 2021
nbusseneau
reviewed
Mar 22, 2021
nbusseneau
reviewed
Mar 22, 2021
nbusseneau
reviewed
Mar 22, 2021
nbusseneau
reviewed
Mar 22, 2021
nebril
force-pushed
the
pr/nebril/gke-workflow-migrate-from-cli
branch
from
29c92ef
to
d7cb51d
Compare
|
Test run that seems to be successful: https://github.com/cilium/cilium/pull/15421/checks?check_run_id=2168532614 (on the PR that has the same code, but EDIT: the test run I linked to above failed 2 connectivity tests with encrypted Cilium install. Will investigate tomorrow. |
nebril
force-pushed
the
pr/nebril/gke-workflow-migrate-from-cli
branch
from
d7cb51d
to
85c162b
Compare
nbusseneau
approved these changes
Mar 23, 2021
This is an adapted workflow from cilium-cli repo Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
nebril
force-pushed
the
pr/nebril/gke-workflow-migrate-from-cli
branch
from
85c162b
to
58d52a3
Compare
joestringer
reviewed
Mar 24, 2021
| - name: Create GKE cluster | ||
| run: | | ||
| gcloud container clusters create ${{ env.clusterName }} \ | ||
| --preemptible \ |
There was a problem hiding this comment.
I'll be curious whether --preemptible has any impact on CI stability. Hopefully no impact.
There was a problem hiding this comment.
Not sure TBH. We will only know if we run it for a bit and get data.
There was a problem hiding this comment.
It will have some impact and we can always just re-run, but yea, from my testing the clusters are sufficiently short-lived that it basically never is an issue. I suppose we'll have to see how it performs for real.
joestringer
approved these changes
Mar 24, 2021
This was referenced Apr 2, 2021
Merged
Merged
nebril
pushed a commit
that referenced
this pull request
Apr 7, 2021
This workflow has been migrated from `cilium-cli` as part of the CI 3.0 initiative, and adapted based on the previous migration made for GKE. See #15416 and #15482 for more details on the structure and adaptations made. Triggers: - `eks.yaml` is triggered automatically when a comment starting with `ci-eks` is made on an PR. In this case, a GitHub status check is manually registered for the PR SHA commit, and will show up in the PR status checks with a link to the workflow run. - `eks.yaml` is also triggered automatically on merge to `master`. In this case a GitHub status check is already automatically registered by the `push` event, so we skip manual status check registering. - A commented `pull_request` trigger is available for workflow developers: it may be uncommented and used in test PRs for testing the workflow using the `ci-run/gke` label (requires write privileges as it will only work for PRs from branches in the Cilium repo, not from fork). Of course it should be left commented for the real PR. Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
nebril
pushed a commit
that referenced
this pull request
Apr 7, 2021
This workflow has been migrated from https://github.com/cilium/cilium-cli/ as part of the CI 3.0 initiative, and adapted based on the previous migration made for GKE. See #15416 and #15482 for more details on the structure and adaptations made. Triggers: - `aks.yaml` is triggered automatically when a comment starting with `ci-aks` is made on an PR. In this case, a GitHub status check is manually registered for the PR SHA commit, and will show up in the PR status checks with a link to the workflow run. - `aks.yaml` is also triggered automatically on merge to `master`. In this case a GitHub status check is already automatically registered by the `push` event, so we skip manual status check registering. - A commented `pull_request` trigger is available for workflow developers: it may be uncommented and used in test PRs for testing the workflow using the `ci-run/gke` label (requires write privileges as it will only work for PRs from branches in the Cilium repo, not from fork). Of course it should be left commented for the real PR. Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an adapted workflow from cilium-cli repo
note - actual gke runs are running in #15421 to actually test these changes, but we want to use pull_request_target here so this PR is actually going to get merged after #15421 passes and reviews are in