Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add AKS workflow #15466

Merged
merged 1 commit into from
Apr 7, 2021
Merged

ci: add AKS workflow #15466

merged 1 commit into from
Apr 7, 2021

Conversation

nbusseneau
Copy link
Member

@nbusseneau nbusseneau commented Mar 25, 2021

This workflow has been migrated from https://github.com/cilium/cilium-cli/ as part of the CI 3.0 initiative, and adapted based on the previous migration made for GKE.

See #15416 and #15482 for more details on the structure and adaptations made.

Triggers:

  • aks.yaml is triggered automatically when a comment starting with ci-aks is made on an PR. In this case, a GitHub status check is manually registered for the PR SHA commit, and will show up in the PR status checks with a link to the workflow run.
  • aks.yaml is also triggered automatically on merge to master. In this case a GitHub status check is already automatically registered by the push event, so we skip manual status check registering.
  • A commented pull_request trigger is available for workflow developers: it may be uncommented and used in test PRs for testing the workflow using the ci-run/gke label (requires write privileges as it will only work for PRs from branches in the Cilium repo, not from fork). Of course it should be left commented for the real PR.

@nbusseneau nbusseneau added the release-note/ci This PR makes changes to the CI. label Mar 25, 2021
@nbusseneau nbusseneau self-assigned this Mar 25, 2021
@nbusseneau nbusseneau requested review from a team as code owners March 25, 2021 13:10
@nbusseneau nbusseneau marked this pull request as draft March 25, 2021 14:31
@nbusseneau
Copy link
Member Author

Testing via #15468.

@nbusseneau
Copy link
Member Author

I've removed the spot nodepool as it seems to be too unwieldy for connectivity tests at the moment... Not a major concern, just too bad we can't use it. Will make a note to retry it later.

@nbusseneau
Copy link
Member Author

Have some issue where coredns goes completely mad once cilium install has ran:

$ kubectl -n kube-system logs coredns-autoscaler-868b684fd4-57zz4 
I0326 19:14:01.889149       1 autoscaler.go:49] Scaling Namespace: kube-system, Target: deployment/coredns
E0326 19:14:06.891012       1 autoscaler_server.go:108] Error while getting cluster status: timed out waiting for the condition
E0326 19:14:16.891274       1 autoscaler_server.go:108] Error while getting cluster status: timed out waiting for the condition
E0326 19:14:21.892836       1 reflector.go:125] github.com/kubernetes-incubator/cluster-proportional-autoscaler/pkg/autoscaler/k8sclient/k8sclient.go:96: Failed to list *v1.Node: Get https://cilium-cli-cilium-cli-ci-69-986ec5-b6a01b83.hcp.westeurope.azmk8s.io:443/api/v1/nodes: dial tcp: lookup cilium-cli-cilium-cli-ci-69-986ec5-b6a01b83.hcp.westeurope.azmk8s.io on 168.63.129.16:53: read udp 10.240.0.26:32776->168.63.129.16:53: i/o timeout
E0326 19:14:26.891013       1 autoscaler_server.go:108] Error while getting cluster status: timed out waiting for the condition

Will troubleshoot on Monday.

@nbusseneau
Copy link
Member Author

nbusseneau commented Mar 29, 2021

Alright so it seems the issue lies with cilium and not the workflow, following up in #15496.

@nbusseneau
Copy link
Member Author

Waiting for #15533 and #15482 to be merged before removing draft status.

This workflow has been migrated from https://github.com/cilium/cilium-cli/
as part of the CI 3.0 initiative, and adapted based on the previous
migration made for GKE.

See #15416 and
#15482 for more details on the
structure and adaptations made.

Triggers:
- `aks.yaml` is triggered automatically when a comment starting with
  `ci-aks` is made on an PR. In this case, a GitHub status check is
  manually registered for the PR SHA commit, and will show up in the PR
  status checks with a link to the workflow run.
- `aks.yaml` is also triggered automatically on merge to `master`. In
  this case a GitHub status check is already automatically registered by
  the `push` event, so we skip manual status check registering.
- A commented `pull_request` trigger is available for workflow
  developers: it may be uncommented and used in test PRs for testing the
  workflow using the `ci-run/gke` label (requires write privileges as it
  will only work for PRs from branches in the Cilium repo, not from
  fork). Of course it should be left commented for the real PR.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
@nbusseneau
Copy link
Member Author

Link to test run for this version of the workflow, from #15468 : https://github.com/cilium/cilium/actions/runs/723298807

@nbusseneau nbusseneau marked this pull request as ready for review April 7, 2021 08:45
@nbusseneau nbusseneau requested a review from aanm April 7, 2021 09:24
@nebril nebril added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 7, 2021
@nebril nebril merged commit fbf3d38 into cilium:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.10.0
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

4 participants