Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: 5.4 CI job #15765

Merged
merged 4 commits into from Apr 29, 2021
Merged

test: 5.4 CI job #15765

merged 4 commits into from Apr 29, 2021

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Apr 19, 2021

This pull request extends our end-to-end tests to support the new 5.4 CI job, aimed at catching complexity issues. At a high level, the commits implements the following.

  1. Rename RunsOnNetNextOr419Kernel to RunsOn419OrLaterKernel as it will include 5.4.
  2. Add RunsOn54Kernel helper function.
  3. Support the 5.4 kernel in our K8sVerifier test.
  4. Skip most tests on 5.4 to run only K8sVerifier and K8sDatapathConfig. Other test suites are not expected to help catch more complexity issues.

Please see commit descriptions for details.

@pchaigno pchaigno added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. labels Apr 19, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Apr 19, 2021
@pchaigno pchaigno force-pushed the 54-ci-job branch 4 times, most recently from b4b82d3 to cba0533 Compare April 22, 2021 08:25
@pchaigno pchaigno marked this pull request as ready for review April 22, 2021 10:28
@pchaigno pchaigno requested a review from a team April 22, 2021 10:28
@pchaigno pchaigno requested review from a team as code owners April 22, 2021 10:28
@pchaigno pchaigno requested review from a team April 22, 2021 10:28
@pchaigno pchaigno requested a review from a team as a code owner April 22, 2021 10:28
@pchaigno pchaigno requested a review from a team April 22, 2021 10:28
@pchaigno pchaigno requested a review from a team as a code owner April 22, 2021 10:28
@pchaigno pchaigno requested a review from joamaki April 22, 2021 10:28
Since the goal of the 5.4 CI job is only to catch complexity issues,
other test suites are skipped. They are not expected to help us catch
new complexity issues compared to K8sVerifier and K8sDatapathConfig.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@qmonnet
Copy link
Member

qmonnet commented Apr 28, 2021

test-me-please

@pchaigno
Copy link
Member Author

test-1.19-5.4

@pchaigno
Copy link
Member Author

The only failing test is in k8s-1.16-kernel-netnext and is due to known flake #15455. The team reviews not yet covered are cilium/policy, cilium/proxy, and cilium/hubble. They are requested only due to commit fbba867 which skips a bunch of tests on the 5.4 pipeline. I don't think they are actually needed because cilium/ci-structure's review should be sufficient for that commit. There are also already four other approving reviews. Marking as ready to merge.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 29, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.0-rc2 Apr 29, 2021
@rolinh rolinh merged commit dfb8220 into cilium:master Apr 29, 2021
1.10.0 automation moved this from In progress to Done Apr 29, 2021
@pchaigno pchaigno deleted the 54-ci-job branch April 29, 2021 15:39
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.7 Apr 30, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.7 Apr 30, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.7 May 6, 2021
@brb brb mentioned this pull request May 7, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.0-rc2 May 7, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.0-rc2 May 13, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.0-rc2 May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.10.0-rc2
Backport done to v1.10
1.9.7
Backport done to v1.9
Development

Successfully merging this pull request may close these issues.

None yet