Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-neigh: Locking, logging, misc improvements #15783

Merged
merged 7 commits into from May 5, 2021
Merged

node-neigh: Locking, logging, misc improvements #15783

merged 7 commits into from May 5, 2021

Conversation

brb
Copy link
Member

@brb brb commented Apr 20, 2021 •
edited

See commit msgs.

/cc @jaffcheng

Fix #15676

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 20, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Apr 20, 2021
@brb brb force-pushed the pr/brb/neigh-arping-locking branch 2 times, most recently from 1309d2a to c3949cc Compare April 22, 2021 16:02
@brb brb changed the title Node neighbor management locking improvements node-neigh: Locking, logging, misc improvements Apr 22, 2021
@brb brb added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. release-note/misc This PR makes changes that have no direct user impact. labels Apr 22, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 22, 2021
@brb brb added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed release-note/misc This PR makes changes that have no direct user impact. labels Apr 22, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 22, 2021
@brb brb requested a review from aanm April 22, 2021 16:43
@brb brb requested a review from gandro April 22, 2021 16:43
@brb brb added the area/daemon Impacts operation of the Cilium daemon. label Apr 22, 2021
@brb brb marked this pull request as ready for review April 22, 2021 16:44
@brb brb requested review from a team April 22, 2021 16:44
@brb brb requested review from a team as code owners April 22, 2021 16:44
@brb brb requested review from jrfastab and twpayne April 22, 2021 16:44
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.10 Apr 22, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.7 Apr 22, 2021
@brb
Copy link
Member Author

brb commented May 5, 2021

The CI failures (#14463 and #15425) are unrelated to my changes. Marking ready to merge.

@brb brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 5, 2021
@joestringer joestringer merged commit 0ff85f2 into master May 5, 2021
1.10.0 automation moved this from In progress to Done May 5, 2021
@joestringer joestringer deleted the pr/brb/neigh-arping-locking branch May 5, 2021 16:19
@brb brb mentioned this pull request May 7, 2021
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.10 May 7, 2021
@brb brb mentioned this pull request May 7, 2021
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.7 May 7, 2021
@brb brb mentioned this pull request May 7, 2021
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.0-rc2 May 7, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.0-rc2 May 7, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.10 May 7, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.7 May 10, 2021
@joestringer joestringer mentioned this pull request May 13, 2021
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.0-rc2 May 13, 2021
@joestringer joestringer mentioned this pull request May 13, 2021
Merged
@aanm aanm mentioned this pull request May 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joamaki joamaki joamaki left review comments

@jaffcheng jaffcheng jaffcheng left review comments

@twpayne twpayne twpayne approved these changes

@gandro gandro gandro approved these changes

@aanm aanm aanm approved these changes

@jrfastab jrfastab Awaiting requested review from jrfastab

Assignees

@twpayne twpayne

@gandro gandro

@jrfastab jrfastab

Labels
area/daemon Impacts operation of the Cilium daemon. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
No open projects
1.10.0
Done
1.10.0-rc2
Backport done to v1.10
1.8.10
Backport done to v1.8
1.9.7
Backport done to v1.9
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve locking and context usage of neighbor manager
9 participants
@brb @aanm @twpayne @gandro @joamaki @jaffcheng @joestringer @jrfastab @ti-mo