Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/kubernetes: add arm64 support for connectivity check #15894

Merged
merged 1 commit into from Apr 28, 2021

Conversation

aanm
Copy link
Member

@aanm aanm commented Apr 28, 2021

This commit adds multi-arch docker images. Now, users can run the
connectivity check in their multi-arch clusters.

Signed-off-by: André Martins andre@cilium.io

Add arm64 support for the connectivity test

This commit adds multi-arch docker images. Now, users can run the
connectivity check in their multi-arch clusters.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.10 labels Apr 28, 2021
@aanm aanm requested a review from a team April 28, 2021 00:09
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.0-rc2 Apr 28, 2021
@aanm
Copy link
Member Author

aanm commented Apr 28, 2021

my assumption is that these scripts / manifests are not used in jenkins tests. If they are feel free to trigger them.

@clementnuss
Copy link

clementnuss commented Apr 28, 2021

Just a message to report that with this commit, test do run on aarch64: I tested it on my RPi4 and it worked flawlessly.
Thanks for the quick fix 👏

@pchaigno
Copy link
Member

pchaigno commented Apr 28, 2021

my assumption is that these scripts / manifests are not used in jenkins tests. If they are feel free to trigger them.

They are, at least in the TProxy test and the Conformance tests:

cilium/test/k8sT/Policies.go

Lines 1771 to 1772 in 4d52791

It("using connectivity-check to check datapath", func() {
kubectl.ApplyDefault(connectivityCheckYml).ExpectSuccess("cannot install connectivity-check")

connectivityCheckYaml = kubectl.GetFilePath("../examples/kubernetes/connectivity-check/connectivity-check-hostport.yaml")
connectivityCheckYamlQuarantine = kubectl.GetFilePath("../examples/kubernetes/connectivity-check/connectivity-check-quarantine.yaml")
connectivityCheckYamlSimple = kubectl.GetFilePath("../examples/kubernetes/connectivity-check/connectivity-check-single-node.yaml")

test-me-please

@aanm aanm merged commit 7f1b1c4 into cilium:master Apr 28, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.0-rc2 Apr 28, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.0-rc2 Apr 28, 2021
@aanm
Copy link
Member Author

aanm commented Apr 28, 2021

@pchaigno It's not the first time I saw this in a different PR. I've opened #15922 to track it

aanm added a commit to cilium/cilium-cli that referenced this pull request Apr 28, 2021
This was merged in cilium/cilium cilium/cilium#15894

Signed-off-by: André Martins <andre@cilium.io>
tklauser added a commit to cilium/cilium-cli that referenced this pull request Apr 29, 2021
Follows cilium/cilium#15894

Also define the image name/version in package defaults.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
aanm added a commit to cilium/cilium-cli that referenced this pull request Apr 29, 2021
This was merged in cilium/cilium cilium/cilium#15894

Signed-off-by: André Martins <andre@cilium.io>
aanm added a commit to cilium/cilium-cli that referenced this pull request Apr 29, 2021
This was merged in cilium/cilium cilium/cilium#15894

Signed-off-by: André Martins <andre@cilium.io>
aanm added a commit to cilium/cilium-cli that referenced this pull request Apr 30, 2021
This was merged in cilium/cilium cilium/cilium#15894

Signed-off-by: André Martins <andre@cilium.io>
aanm added a commit to cilium/cilium-cli that referenced this pull request Apr 30, 2021
This was merged in cilium/cilium cilium/cilium#15894

Signed-off-by: André Martins <andre@cilium.io>
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.0-rc2 May 6, 2021
aditighag pushed a commit to aditighag/cilium-cli that referenced this pull request Apr 21, 2023
This was merged in cilium/cilium cilium/cilium#15894

Signed-off-by: André Martins <andre@cilium.io>
michi-covalent pushed a commit to michi-covalent/cilium that referenced this pull request May 30, 2023
This was merged in cilium/cilium cilium#15894

Signed-off-by: André Martins <andre@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0-rc2
Backport done to v1.10
Development

Successfully merging this pull request may close these issues.

None yet

6 participants