v1.10 backports 2021-04-28 #15919
Merged
v1.10 backports 2021-04-28 #15919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christarazi
added
backport/1.10
kind/backports
|
test-backport-1.10 |
rolinh
approved these changes
Apr 28, 2021
joestringer
approved these changes
Apr 29, 2021
There was a problem hiding this comment.
Commits from me look fine 👍
Looks like the upgrade tests fail, this may be the first PR on the v1.10 branch to run through CI so maybe we just missed something while branching:
/home/jenkins/workspace/Cilium-PR-K8s-1.19-kernel-4.9/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:518
Cilium image didn't update correctly
Expected
<string>: sha256:e931dc19369a5e0a3273b36407ba97fbc9379c2fc2c19eac78932e5658668a4d
to contain substring
<string>: 6426432f93cb717b5f39f92fabc77ada2a2b0b86
/home/jenkins/workspace/Cilium-PR-K8s-1.19-kernel-4.9/src/github.com/cilium/cilium/test/k8sT/Updates.go:478
Looks like something in the test is hardcoding expectations around Cilium docker image digests.
gandro
approved these changes
May 3, 2021
[ upstream commit 6fcdb29 ] Reuse the logic from the backporting cherrypick commit for determining that the commit is upstream before tagging and pushing the tags for release preparation. This should catch errors where the tagged release version is not a commit in the branch where the release is made. Signed-off-by: Joe Stringer <joe@cilium.io> Signed-off-by: Chris Tarazi <chris@isovalent.com>
[ upstream commit a5f6fbb ] v1.10 is the first release we did with so many digits, which helped us find all sorts of fun limitations in our scripts; fix them up. Signed-off-by: Joe Stringer <joe@cilium.io> Signed-off-by: Chris Tarazi <chris@isovalent.com>
[ upstream commit 5669f97 ] Signed-off-by: André Martins <andre@cilium.io> Signed-off-by: Chris Tarazi <chris@isovalent.com>
[ upstream commit 47587d3 ] Signed-off-by: André Martins <andre@cilium.io> Signed-off-by: Chris Tarazi <chris@isovalent.com>
[ upstream commit 7f1b1c4 ] This commit adds multi-arch docker images. Now, users can run the connectivity check in their multi-arch clusters. Signed-off-by: André Martins <andre@cilium.io> Signed-off-by: Chris Tarazi <chris@isovalent.com>
[ upstream commit beb467f ] Description: Issue: It states that 429 response code is not honored inside cilium. What is 429 response? This 429 response code is returned by the server when there are Too many requests in a given time frame Root cause:: We observed that cilium is not handling the 429 response code when multiple pods are created at the same time. Fix: We have introduced a change for the support of handling 429 response code in the openapi.yaml. Fixes: cilium#14922 Signed-off-by: Maddy007-maha <mahadev.panchal@accuknox.com> Signed-off-by: Chris Tarazi <chris@isovalent.com>
[ upstream commit efb3a72 ] This adds support for device name wildcards to the "--devices" option, e.g. if user specifies "--devices=eth+,en+" the agent will match devices eth0, eth1, en0, etc. Fixes: cilium#15693 Signed-off-by: Jussi Maki <jussi@isovalent.com> Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
force-pushed
the
pr/v1.10-backport-2021-04-28
branch
from
6426432
to
050a01c
Compare
|
Waiting on #15947 to be merged, then I'll pull it in and it should unblock v1.10 CI. Edit: It's been added |
[ upstream commit 1ac77fc ] CI runs don't need to use image digests, as there's no real benefit. Additionally, the CI infrastructure is not set up to properly parse the digests from the image tag, which causes the upgrade test (test/k8sT/Updates.go). Signed-off-by: Chris Tarazi <chris@isovalent.com>
|
test-backport-1.10 Edit: net-next hit #12511 |
joestringer
approved these changes
May 6, 2021
|
Marking as ready to merge as CI has passed (despite GH wonky UI display of jobs not started--they have) and we have author sign-offs. |
christarazi
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, you can update the PR labels via: