contrib: Ensure release tag is upstream before push #15903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
added
needs-backport/1.10
release-note/misc
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
joestringer
force-pushed
the
queue/fix-wrong-tag-version
branch
from
bcbed9a
to
f410673
Compare
Reuse the logic from the backporting cherrypick commit for determining that the commit is upstream before tagging and pushing the tags for release preparation. This should catch errors where the tagged release version is not a commit in the branch where the release is made. Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
force-pushed
the
queue/fix-wrong-tag-version
branch
from
f410673
to
e2c99d4
Compare
aanm
approved these changes
Apr 28, 2021
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.0-rc2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.7
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.10
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.10
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.0-rc2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.7
This was referenced May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse the logic from the backporting cherrypick commit for determining
that the commit is upstream before tagging and pushing the tags for
release preparation. This should catch errors where the tagged release
version is not a commit in the branch where the release is made.